Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Commit

Permalink
Add TODO with the related issues for Tracer.testTracer test.
Browse files Browse the repository at this point in the history
Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <[email protected]>
  • Loading branch information
mdouaihy committed Sep 4, 2019
1 parent 462b318 commit c253bb4
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion src/jaegertracing/TracerTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ TEST(Tracer, testTracer)
options)
.release()));
/*
TODO: https://github.com/jaegertracing/jaeger-client-cpp/issues/167
const auto calculatedSystemTime =
static_cast<Tracer::SystemClock::time_point>(
opentracing::convert_time_point<Tracer::SystemClock>(
Expand All @@ -238,7 +239,9 @@ TEST(Tracer, testTracer)
static_cast<Tracer::SteadyClock::time_point>(
opentracing::convert_time_point<Tracer::SteadyClock>(
span->startTimeSystem()));
/*ASSERT_GE(std::chrono::milliseconds(10),
/*
TODO: https://github.com/jaegertracing/jaeger-client-cpp/issues/167
ASSERT_GE(std::chrono::milliseconds(10),
absTimeDiff<Tracer::SteadyClock>(span->startTimeSteady(),
calculatedSteadyTime));
Expand All @@ -247,11 +250,15 @@ TEST(Tracer, testTracer)
span.reset(static_cast<Span*>(
tracer->StartSpanWithOptions("test-span-with-both-timestamps", options)
.release()));
// TODO: https://github.com/jaegertracing/jaeger-client-cpp/issues/167

// ASSERT_EQ(options.start_system_timestamp, span->startTimeSystem());
// ASSERT_EQ(options.start_steady_timestamp, span->startTimeSteady());

span.reset();

// TODO: https://github.com/jaegertracing/jaeger-client-cpp/issues/127

// There is a problem here. After replacing the global tracer, the spans
// produced hold the last references to the tracer. After they are
// published, the tracer is destroyed. This is not the right moment to close
Expand Down

0 comments on commit c253bb4

Please sign in to comment.