Use jaeger storage integration helpers from upstream #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @pavolloffay |
This commit deletes local copy of test helpers and fixtures and imports related package from upstream jaeger as a golang pkg. Signed-off-by: Arunprasad Rajkumar <[email protected]>
arajkumar
force-pushed
the
use-integration-test-from-upstream
branch
from
9232172
to
37b2564
Compare
|
I no longer maintain this repo. @nickbp or other folks, could you please take a look? |
Signed-off-by: Arunprasad Rajkumar <[email protected]>
|
Thanks for the cleanup, as well as the CI fix! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
jaeger-clickhouse copies upstream storage integration test helpers and fixtures
Short description of the changes
Recently a PR has been merged into upstream jaeger which exposes storage integration test helpers as a go pkg. This PR updates the go.mod to make use of the exposed package and removes all local copies of test helpers and fixtures.
Signed-off-by: Arunprasad Rajkumar [email protected]