Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jaeger to 1.17.0 #55

Merged
merged 2 commits into from
Feb 29, 2020
Merged

Conversation

naseemkullah
Copy link
Member

Signed-off-by: Naseem [email protected]

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The Operator will be released soon as well. Would you prefer to have both bumps as part of different commits, or would you prefer to wait for the Operator bump before merging this?

@naseemkullah
Copy link
Member Author

LGTM. The Operator will be released soon as well. Would you prefer to have both bumps as part of different commits, or would you prefer to wait for the Operator bump before merging this?

Thanks for pointing that out @jpkrohling, I updated operator to 1.17 assuming that it all released at the same time. So I will wait to merge as you've mentioned it will be released soon.

@jpkrohling
Copy link
Contributor

jpkrohling commented Feb 27, 2020

The Jaeger Operator v1.17.0 has just been released. Note that we found a breaking change affecting users of Kafka as the storage backend and/or ingester when TLS is enabled. Not sure there's anything you can do in the Helm side, but you might want to take a look at our upgrade mechanisms in the operator, to see what we are doing there to address this.

This is the issue description: jaegertracing/jaeger#2092

And this is the upgrade code we have:
https://github.com/jaegertracing/jaeger-operator/blob/c9147e7ec923113b2dbeafc917c8eb0070c7dc8e/pkg/upgrade/v1_17_0.go#L51-L67

Signed-off-by: Naseem <[email protected]>
Signed-off-by: Naseem <[email protected]>
@naseemkullah naseemkullah merged commit 08092b3 into jaegertracing:master Feb 29, 2020
@naseemkullah naseemkullah deleted the to-1.17.0 branch March 13, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants