Add Badger v1 to v3 migration steps #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashmita Bohara <[email protected]>
jpkrohling
approved these changes
Jun 24, 2021
yurishkuro
reviewed
Jun 24, 2021
| @@ -171,6 +171,117 @@ docker run \ | |||
| jaegertracing/all-in-one:{{< currentVersion >}} | |||
| ``` | |||
|
|
|||
| #### Upgrade Badger v1 to v3 | |||
There was a problem hiding this comment.
We usually do not keep such detailed migration instructions in the core documentation - they are going to become irrelevant soon, but the docs are "forever". I would instead create an .md file in the badger dir in the main repo and link to that file from the changelog.
There was a problem hiding this comment.
True, I think it might be useful to have it here for this version, and remove for the next one, keeping the doc in the readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashmita Bohara [email protected]
Which problem is this PR solving?
Update documentation with steps to migrate from badger v1 to v3
/cc @jpkrohling