Add archive traces UI configuration #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
ghost
assigned 
objectiser
approved these changes
Nov 15, 2018
|
you can raise it in the UI repo |
|
Thinking about this, Not sure if there are more conf props for the archive. I think dependencies is an object because there are two properties. |
yurishkuro
reviewed
Nov 16, 2018
| @@ -340,6 +341,8 @@ An example configuration file: | |||
|
|
|||
| `dependencies.menuEnabled` enables (`true`) or disables (`false`) the dependencies menu button. Default: `true`. | |||
|
|
|||
| `archiveEnabled` enables (`true`) or disables (`false`) the archive traces button. Default: `false`. It requires a configuration of an archive storage in Query service. | |||
There was a problem hiding this comment.
It might be useful to explain what "archiving" means", given this confusion: jaegertracing/jaeger#818 (comment)
|
+1 will clarify
…On Fri, Nov 16, 2018 at 1:28 AM Yuri Shkuro ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In content/docs/1.6/deployment.md
<#171 (comment)>
:
> @@ -340,6 +341,8 @@ An example configuration file:
`dependencies.menuEnabled` enables (`true`) or disables (`false`) the dependencies menu button. Default: `true`.
+`archiveEnabled` enables (`true`) or disables (`false`) the archive traces button. Default: `false`. It requires a configuration of an archive storage in Query service.
It might be useful to explain what "archiving" means", given this
confusion: jaegertracing/jaeger#818 (comment)
<jaegertracing/jaeger#818 (comment)>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#171 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFW6-PuaoQdjdQAohSF9MjATAXgSFIfnks5uvga-gaJpZM4Yf7iJ>
.
|
|
@pavolloffay You're right, the I commented with trade-offs to both approaches in the UI ticket: jaegertracing/jaeger-ui#277 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay [email protected]
Resolves: jaegertracing/jaeger-ui#7