Review fixes for timestamp_ns API changes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
force-pushed
the
jgm-timestamp-nanos-api
branch
from
448f797 to
dedeb19
Compare
rdblue
commented
Aug 23, 2024
| return Math.toIntExact(convertNanos(nanos, ChronoUnit.HOURS)); | ||
| } | ||
|
|
||
| private static long convertNanos(long nanos, ChronoUnit granularity) { |
Author
There was a problem hiding this comment.
No need to expose ChronoUnit from this API. I think this fits with the existing conventions better and is more clear.
rdblue
commented
Aug 25, 2024
| } | ||
|
|
||
| @Override | ||
| public boolean satisfiesOrderOf(Transform<?, ?> other) { |
Author
There was a problem hiding this comment.
I standardized this implementation across TimeTransform, Dates, and Timestamps and added thorough testing.
jacobmarble
approved these changes
Aug 26, 2024
Owner
jacobmarble
left a comment
jacobmarble
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the added tests and comments!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I go through apache#9008, I'll go ahead and make changes and accumulate them here.