Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroneously matches sub-words? #186

Closed
dleslie opened this issue Dec 14, 2017 · 5 comments
Closed

Erroneously matches sub-words? #186

dleslie opened this issue Dec 14, 2017 · 5 comments

Comments

@dleslie
Copy link
Contributor

dleslie commented Dec 14, 2017

I noticed this behaviour just after submitting the Scheme support, but it matches the existing behaviour found in the elisp support.

I think it's best described in code:
dleslie@47bd476

Should those new not tests pass? They do not at present, and I suspect it's because \\j word boundaries aren't working as intended. Unless the intent is to match sub-words. ;)

@jacktasia
Copy link
Owner

Thanks for opening this! This is probably related to this: #181 and #179 That is, it's about what emacs is getting at point. I think. You can verify by turning on the debug flag which is described in the readme. Please let me know what you find. Thanks!

@dleslie
Copy link
Contributor Author

dleslie commented Dec 14, 2017

I was under the impression the not tests were applied directly to the underlying search provider, be it rg, ag or other? Anyhow...

For this:
(defun tester () ...)

thing-at-point will be tester for either sexp or symbol; but I'm looking for the definition of test. I can see people wanting this sort of result to show up, however, because they may be trying to recall the full name of a function that they can only recall the prefix for. Hence the bug in the form of a question. 😄

@jacktasia
Copy link
Owner

Ohhh, I see now. Sorry, when I first read this it was on my phone and clearly read it too fast and assumed it was the issue(s) I mentioned. I see what you're saying now and will look closer soon.

jacktasia added a commit that referenced this issue Dec 14, 2017
@netromdk
Copy link
Contributor

netromdk commented Jan 9, 2018

This issue can be closed now, right @jacktasia?

@jacktasia
Copy link
Owner

@netromdk Yeah, that's my understanding. I am closing it. @dleslie Please let me know if you're still running into issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants