Issue #337 #345
Merged
Issue #337 #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksontj
force-pushed
the
issue_337
branch
from
ab17a03 to
b3038ca
Compare
The majority of times there are holes in the data a single downstream has a hole but the other has the data; in that case since we have the data in memory there is no reason to chose the "worse" data and merge from there. This has the caveat that this is done on a per-merge basis; so if there are N servers and the first 2 return with holes they will be merged; but due to anti-affinity if there is any server with no hole it will always have more points than a merged series.
jacksontj
force-pushed
the
issue_337
branch
from
4d3eff2 to
cdad378
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.