Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error and warning messages on void elements #81

Merged
merged 11 commits into from
Nov 17, 2020

Conversation

jackdomleo7
Copy link
Owner

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Adds error and warning messages to void elements (elements that do not have the ability to render a ::before and ::after by rendering an SVG instead as a background-image - this feature was already implemented in a previous PR, this is just refactoring and adding to every void element.
  • Updated README to look better
  • Updated dependencies
  • Resolves Show error/warning messages on elements that don't accept ::before and ::after #52

Link(s)

N/A

Screenshot(s)

image

Checklist:

  • I have thoroughly read the CONTRIBUTING guidelines.
  • I understand my pull request will be thoroughly reviewed at high detail.
  • I understand the work in my pull request will only be available in the next version release of Checka11y.css and not in the current version release.
  • I confirm the work in this pull request is valid according to my findings and is not something for anything personal.
  • I have updated the README and/or features.md where and if applicable (still put an x if you have considered this but thought there was nothing to add or modify).
  • I have added myself to the contributors section in package.json (still put an x if you have considered this but decided not to add yourself).
  • I have checked I have not committed any accidental files.
  • I have tested all the main modern browsers (I.e. Chrome, Firefox, Edge, Safari - please leave this unchecked if there were any browsers listed you could not test and list them in the help section with details why you couldn't test that browser)
  • I have run the automated tests and added new ones to cover new code.
  • All new and existing a11y checks still work correctly (compare your local test/index.html to the test/index.html in the master branch).

Help

Unable to test Safari.

@jackdomleo7 jackdomleo7 added the project enhancement Enhancement to improving the overall project label Nov 17, 2020
@jackdomleo7 jackdomleo7 self-assigned this Nov 17, 2020
@jackdomleo7 jackdomleo7 merged commit 7fe9322 into master Nov 17, 2020
@jackdomleo7 jackdomleo7 deleted the error_and_warning_messages_on_void_elements branch November 17, 2020 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project enhancement Enhancement to improving the overall project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show error/warning messages on elements that don't accept ::before and ::after
1 participant