Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cypress from version 6 to 8.7.0 #150

Merged
merged 3 commits into from
Nov 8, 2021
Merged

Update Cypress from version 6 to 8.7.0 #150

merged 3 commits into from
Nov 8, 2021

Conversation

tannerdolby
Copy link
Contributor

@tannerdolby tannerdolby commented Nov 7, 2021 •
edited
Loading

Description

Fixes #113
Cleans up #147

This PR includes all signed commits :)

Why is this important?

In Cypress 8:

  • All browsers run headless by default so the --headless flag can be removed from any cypress run usage
  • The default screen size when running a headless browser reverted back to 1280x720 pixels

Covered test cases

No test cases were added or modified.

Did you test on all major browsers?

  • Chrome
  • Firefox
  • Edge
  • Safari

Other details

T&Cs

  • I confirm I have read and understand the contributing guidelines
  • I understand the work in this pull request will not be released straight away and will appear in a future release (if approved)
  • I confirm the work in this pull request is true and valid to the best of my knowledge
  • I have updated the README, features.md and codes.md files where applicable

jackdomleo7
jackdomleo7 approved these changes Nov 8, 2021
View reviewed changes
Copy link
Owner

@jackdomleo7 jackdomleo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thank you!

@jackdomleo7 jackdomleo7 added the project enhancement Enhancement to improving the overall project label Nov 8, 2021
@jackdomleo7 jackdomleo7 merged commit d1def38 into jackdomleo7:master Nov 8, 2021
@tannerdolby tannerdolby deleted the 113-update-cypress-version branch November 8, 2021 15:53
@tannerdolby
Copy link
Contributor Author

tannerdolby commented Nov 8, 2021 •
edited
Loading

No problem! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackdomleo7 jackdomleo7 jackdomleo7 approved these changes

Assignees

@tannerdolby tannerdolby

Labels
project enhancement Enhancement to improving the overall project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update from Cypress 6 to Cypress 8
2 participants
@tannerdolby @jackdomleo7