Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 929 #968

Merged
merged 4 commits into from
Jan 28, 2024
Merged

Issue 929 #968

merged 4 commits into from
Jan 28, 2024

Conversation

jackdewinter
Copy link
Owner

#929 - try 2

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Documentation

PR Summary: The pull request addresses the issue of incorrect URLs in the documentation by updating them to the correct paths. It also includes a change in the Markdown rule plugin to handle trailing whitespace in ATX headings correctly.

Decision: Comment

📝 Type: 'Documentation' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Ensure that all updated URLs are tested to confirm they lead to the correct resources.
  • Consider adding a brief description in the changelog about why the trailing whitespace handling for ATX headings was necessary, providing more context for the change.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@jackdewinter jackdewinter merged commit 0dd6170 into main Jan 28, 2024
11 checks passed
@jackdewinter jackdewinter deleted the issue-966 branch January 28, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant