-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrades #1256
base: main
Are you sure you want to change the base?
upgrades #1256
Conversation
Reviewer's Guide by SourceryThis PR primarily focuses on upgrading build libraries and refactoring test code. The main changes include updating dependency versions in Pipfile, refactoring test_md012.py to use parameterized tests, and fixing an issue with blank lines separated by pragmas. Class diagram for test_md012.py refactoringclassDiagram
class test_md012 {
+execute_scan_test(test: pluginRuleTest, rule: str)
+execute_configuration_test(test: pluginRuleTest, file: str)
}
class pluginRuleTest
class pluginConfigErrorTest
class id_test_plug_rule_fn
test_md012 --> pluginRuleTest
test_md012 --> pluginConfigErrorTest
test_md012 --> id_test_plug_rule_fn
note for test_md012 "Refactored to use parameterized tests"
Class diagram for rule_md_012.py changesclassDiagram
class RuleMd012 {
-__last_blank_line: MarkdownToken
-__blank_line_count: int
+next_token(context: PluginScanContext, token: MarkdownToken)
}
class PluginScanContext
class MarkdownToken {
+is_blank_line: bool
+line_number: int
}
RuleMd012 --> PluginScanContext
RuleMd012 --> MarkdownToken
note for RuleMd012 "Added logic to check for excess blank lines"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jackdewinter - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1256 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 191 191
Lines 21194 21197 +3
Branches 2715 2716 +1
=======================================
+ Hits 21190 21193 +3
Misses 1 1
Partials 3 3 ☔ View full report in Codecov by Sentry. |
upgrading build libraries
Summary by Sourcery
Refactor test cases for rule MD012 to use parameterized tests and update dependencies in the Pipfile. Enhance test coverage by adding new test cases and update the changelog with recent fixes.
Enhancements:
Build:
Documentation:
Tests: