Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1007 #1020

Merged
merged 3 commits into from
Mar 17, 2024
Merged

Issue 1007 #1020

merged 3 commits into from
Mar 17, 2024

Conversation

jackdewinter
Copy link
Owner

No description provided.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jackdewinter - I've reviewed your changes and they look great!

General suggestions:

  • Consider simplifying the implementation to reduce complexity and improve maintainability.
  • Ensure that new methods and logic introduced are well-documented to aid in future development.
  • Review the necessity and implementation of newly introduced methods to ensure they align with the project's coding standards and practices.
Here's what I looked at during the review
  • 🟡 General issues: 5 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 3 issues found
  • 🟢 Docstrings: all looks good

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

pymarkdown/plugins/rule_md_023.py Show resolved Hide resolved
pymarkdown/plugins/rule_md_023.py Show resolved Hide resolved
pymarkdown/plugins/rule_md_023.py Show resolved Hide resolved
pymarkdown/plugins/rule_md_023.py Show resolved Hide resolved
pymarkdown/plugins/rule_md_023.py Show resolved Hide resolved
pymarkdown/inline/inline_text_block_helper.py Show resolved Hide resolved
pymarkdown/plugins/rule_md_023.py Show resolved Hide resolved
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (32ca849) to head (5c2672b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main     #1020    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          189       189            
  Lines        19456     19585   +129     
  Branches      2419      2444    +25     
==========================================
+ Hits         19456     19585   +129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jackdewinter jackdewinter merged commit 88c7c98 into main Mar 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant