Require 'Date' in date_extensions.rb #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling gem from a little command-line script, I was getting the following error: ``` ~/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/tod-2.0.2/lib/tod/date_extensions.rb:15:in `<top (required)>': uninitialized constant Date (NameError) from /Users/ambirdsall/.rbenv/versions/2.2.2/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require' from /Users/ambirdsall/.rbenv/versions/2.2.2/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require' from /Users/ambirdsall/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/tod-2.0.2/lib/tod/core_extensions.rb:1:in `<top (required)>' from /Users/ambirdsall/.rbenv/versions/2.2.2/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require' from /Users/ambirdsall/.rbenv/versions/2.2.2/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require' ``` This adds an explicit `require 'Date'` to the offending file so that this can be used outside of bundled environments where the `Date` class is preloaded.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used
todto write a little command-line script that would return a different emoji for my terminal prompt based on the time of day (:coffee: in the AM, :beer: at 6:30, 🌒 when I need to go tf to bed, etc). I was getting the following error:This adds an explicit
require 'Date'to the offending file so that this can be used in a self-contained way outside of environments like rails where theDateclass comes preloaded.cf. neo4jrb/activegraph#852