Move sender API to new opentelemetry-exporter-sender-api artifact#21
Closed
jack-berg wants to merge 1 commit intopublic-sender-apifrom
Closed
Move sender API to new opentelemetry-exporter-sender-api artifact#21jack-berg wants to merge 1 commit intopublic-sender-apifrom
jack-berg wants to merge 1 commit intopublic-sender-apifrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move sender API to new
opentelemetry-exporter-sender-apiartifact.The idea here is to create an artifact that senders can depend on without bringing unrelated cruft in.
It breaks down because sender API depends on
RetryPolicy,ProxyOptionsandCompletableResultCodefromopentelemetry-sdk-common.Its not really practical to move these classes to this new
opentelemetry-exporter-sender-apibecause other public APIs depend on them (i.e.SpanExporter,OtlpHttpSpanExporterBuilder) as part of their public API.So I don't think this is a realistic option, or at least not particularly beneficial. Just more artifacts without gaining much in return.