[pull] main from redwoodjs:main

.eslintrc.js

@@ -15,70 +15,31 @@ const findBabelConfig = (cwd = process.cwd()) => {
 module.exports = {
   extends: path.join(__dirname, 'packages/eslint-config/shared.js'),
   parserOptions: {
+    ecmaVersion: 'latest',
     babelOptions: {
       configFile: findBabelConfig(),
     },
   },
   ignorePatterns: [
     'dist',
     'fixtures',
-    'packages/structure/**',
     'packages/internal/src/build/babelPlugins/__tests__/__fixtures__/**/*',
     'packages/core/**/__fixtures__/**/*',
     'packages/codemods/**/__testfixtures__/**/*',
     'packages/core/config/storybook/**/*',
-    'packages/create-redwood-app/template/web/src/Routes.tsx',
   ],
   rules: {
     '@typescript-eslint/no-explicit-any': 'off',
-    'import/order': [
-      'error',
-      {
-        'newlines-between': 'always',
-        pathGroupsExcludedImportTypes: ['react'],
-        pathGroups: [
-          {
-            pattern: 'react',
-            group: 'builtin',
-            position: 'after',
-          },
-          {
-            pattern: '@redwoodjs/**',
-            group: 'external',
-            position: 'after',
-          },
-          {
-            pattern: 'src/lib/test',
-            group: 'parent',
-            position: 'before',
-          },
-          {
-            pattern: 'src/**',
-            group: 'parent',
-            position: 'before',
-          },
-        ],
-        alphabetize: {
-          order: 'asc',
-          caseInsensitive: true,
-        },
-      },
-    ],
     curly: 'error',
   },
+  env: {
+    // We use the most modern environment available. Then we rely on Babel to
+    // transpile it to something that can run on all node versions we support
+    es2022: true,
+  },
   overrides: [
     {
-      // We override import order of the CRWA graphql function because we want the grouped glob imports
-      // to be ordered separately.
-      // Note: for some reason, the pattern as eslints each file to match against the pattern
-      // the files pattern has to be the filename and not the relative path (as one might expect)
-      files: ['graphql.ts'],
-      rules: {
-        'import/order': 'off',
-      },
-    },
-    {
-      files: ['packages/structure/**'],
+      files: ['packages/structure/src/**'],
       rules: {
         '@typescript-eslint/no-this-alias': 'off',
         '@typescript-eslint/no-non-null-assertion': 'off',
@@ -101,19 +62,49 @@ module.exports = {
         'packages/web/src/**',
       ],
       env: {
-        es6: true,
         browser: true,
       },
       globals: {
         React: 'readonly', // We auto-import React via Babel.
         window: 'off', // Developers should use `global` instead of window. Since window is undefined in NodeJS.
       },
     },
+    // Prevent @redwoodjs/internal imports in runtime (web+api) packages
+    {
+      files: [
+        'packages/auth/src/**',
+        'packages/forms/src/**',
+        'packages/prerender/src/browserUtils/**',
+        'packages/router/src/**',
+        'packages/web/src/**',
+        'packages/api/src/**',
+        'packages/graphql-server/src/**',
+        'packages/record/src/**',
+      ],
+      rules: {
+        'no-restricted-imports': [
+          'error',
+          {
+            patterns: [
+              {
+                group: ['@redwoodjs/internal', '@redwoodjs/internal/*'],
+                message:
+                  'Do not import "@redwoodjs/internal" or subpackages in runtime modules, because it leads to MASSIVE bundle sizes',
+              },
+              {
+                group: ['@redwoodjs/structure', '@redwoodjs/structure/*'],
+                message:
+                  'Do not import "@redwoodjs/structure" or subpackages in runtime modules, because it leads to MASSIVE bundle sizes',
+              },
+            ],
+          },
+        ],
+      },
+    },
     // Entry.js rules
     {
       files: ['packages/web/src/entry/index.js'],
       env: {
-        es6: true,
         browser: true,
       },
       globals: {
@@ -138,9 +129,44 @@ module.exports = {
         'packages/telemetry/src/**',
       ],
       env: {
-        es6: true,
         node: true,
       },
     },
+    // Prevent bad imports in Node packages - cli and api packages
+    {
+      files: [
+        'packages/api/src/**',
+        'packages/api-server/src/**',
+        'packages/cli/src/**',
+        'packages/internal/src/**',
+        'packages/prerender/src/**',
+        'packages/structure/src/**',
+        'packages/testing/src/**',
+        'packages/testing/config/**',
+        'packages/eslint-config/*.js',
+        'packages/record/src/**',
+        'packages/telemetry/src/**',
+      ],
+      rules: {
+        'no-restricted-imports': [
+          // for import x from ('@redwoodjs/internal')
+          'error',
+          {
+            name: '@redwoodjs/internal',
+            message:
+              'To prevent bloat in CLI, do not import "@redwoodjs/internal" directly. Instead import like @redwoodjs/internal/dist/<file>, or await import',
+          },
+        ],
+        'no-restricted-modules': [
+          // for require('@redwoodjs/internal')
+          'error',
+          {
+            name: '@redwoodjs/internal',
+            message:
+              'To prevent bloat in CLI, do not require "@redwoodjs/internal" directly. Instead require like @redwoodjs/internal/dist/<file>',
+          },
+        ],
+      },
+    },
   ],
 }

.github/ISSUE_TEMPLATE/bug-report.yml

@@ -0,0 +1,83 @@
+name: "🐛 Bug report"
+description: "Something not working the way it should be?"
+
+title: "[Bug?]: "
+labels: bug/needs-info
+
+body:
+  - type: textarea
+    attributes:
+      label: What's not working?
+      description: >
+        Describe the bug here.
+        The more detail you provide, the better,
+        but try to start with a summary to frame the issue.
+    validations:
+      required: true
+
+  - type: textarea
+    attributes:
+      label: How do we reproduce the bug?
+      description: >
+        What commands do we need to run?
+        Are there any packages that we need to install?
+        What does the `schema.prisma` need to look like?
+        Maybe include a link to a GitHub repo or a Gitpod snapshot? ([Instructions here](https://github.com/redwoodjs/redwood/blob/main/CONTRIBUTING.md#Creating-a-reproduction-to-include-with-issues).)
+
+
+        While this field is optional,
+        you're much more likely to get a timely response and fix from us if you fill it out.
+        Issues without reproductions are much harder for us to debug.
+    validations:
+        required: false
+
+  - type: textarea
+    attributes:
+      label: What's your environment? (If it applies)
+      render: shell
+      description: |
+        Run `yarn rw info` and paste the output here.
+      placeholder: |
+        System:
+          OS: macOS 12.3.1
+          Shell: 5.8 - /bin/zsh
+        Binaries:
+          Node: 16.15.1 - /private/var/folders/dt/yks4v5m53k114qxgz6jh4pgw0000gn/T/xfs-0cbbe6f7/node
+          Yarn: 3.2.1 - /private/var/folders/dt/yks4v5m53k114qxgz6jh4pgw0000gn/T/xfs-0cbbe6f7/yarn
+        Databases:
+          SQLite: 3.37.0 - /usr/bin/sqlite3
+        Browsers:
+          Chrome: 102.0.5005.115
+          Safari: 15.4
+        npmPackages:
+          @redwoodjs/core: 1.5.2 => 1.5.2
+    validations:
+        required: false
+
+  - type: checkboxes
+    attributes:
+      label: Are you interested in working on this?
+      description: >
+        No pressure—this is totally optional!
+        We just want to invite you to contribute to Redwood.
+        If you choose to contribute, the core team will be there to help you the whole way.
+
+
+        If this issue is triaged as lower priority,
+        your willing and ableness to work on it will land it faster than waiting for one of us to pick it up.
+      options:
+        - label: I'm interested in working on this
+
+  - type: markdown
+    attributes:
+      value: >
+        ---
+
+        **About to submit this? Wait!**
+
+
+        Nice work! 👏 Now that you're all done,
+        take a moment to reread your issue's title.
+        Is it descriptive enough?
+        Does it still ring true? 🤔
+        If not, take a moment to rewrite it.

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,8 @@
+blank_issues_enabled: false
+contact_links:
+  - name: ❓ Have a question or need help?
+    url: https://community.redwoodjs.com/new-topic?category=get-help-and-help-others
+    about: >
+      Have a question about the way Redwood works?
+      Or not sure if you're doing something right?
+      Ask us over on the forums

.github/ISSUE_TEMPLATE/documentation.yml

@@ -0,0 +1,44 @@
+name: "📖 Documentation"
+description: "A catch-all template for issues about documentation"
+
+title: "[Docs]: "
+labels: topic/docs
+
+body:
+  - type: textarea
+    attributes:
+      label: Summary and description
+      description: >
+        The body of the issue, just like a regular GitHub issue.
+        The more detail you provide, the better,
+        but try to start with a summary to frame the issue.
+    validations:
+      required: true
+
+  - type: checkboxes
+    attributes:
+      label: Are you interested in working on this?
+      description: >
+        No pressure—this is totally optional!
+        We just want to invite you to contribute to Redwood.
+        If you choose to contribute, the core team will be there to help you the whole way.
+
+
+        If this issue is triaged as lower priority,
+        your willing and ableness to work on it will land it faster than waiting for one of us to pick it up.
+      options:
+        - label: I'm interested in working on this
+
+  - type: markdown
+    attributes:
+      value: >
+        ---
+
+        **About to submit this? Wait!**
+
+
+        Nice work! 👏 Now that you're all done,
+        take a moment to reread your issue's title.
+        Is it descriptive enough?
+        Does it still ring true? 🤔
+        If not, take a moment to rewrite it.

.github/ISSUE_TEMPLATE/rfc.yml

@@ -0,0 +1,81 @@
+name: "💬 RFC"
+description: "For detailed proposals about new features or changes to existing ones"
+
+title: "[RFC]: "
+
+body:
+  - type: markdown
+    attributes:
+      value: >
+        Thanks for taking the time to open an RFC!
+        Please note that this is for detailed proposals.
+        If you have a feature request, or would like to brainstorm,
+        the [forums](https://community.redwoodjs.com/) is a better place to start.
+
+  - type: textarea
+    attributes:
+      label: Summary
+      description: >
+        Start with a summary to frame the proposal.
+        If the proposal involves a new API or a change to an existing one,
+        including a code example upfront goes a long way.
+    validations:
+      required: true
+
+  - type: textarea
+    attributes:
+      label: Motivation
+      description: >
+        Here your goal is to answer the question "Why are we doing this?"
+        As put by other RFC templates,
+        "enumerate the constraints you're trying to solve
+        without coupling them too closely to the solution you have in mind."
+    validations:
+      required: true
+
+  - type: textarea
+    attributes:
+      label: Detailed proposal
+      description: |
+        Write your proposal here. You're welcome to structure it however you like, but the more detail, the better. Get into the specifics and include examples. Keep this non-exhaustive list of questions in mind as you write:
+
+        - What's this about? (The CLI? The web side? The api side? Both?)
+        - What's the design in detail?
+        - Is this a breaking change? How easy will it be for existing Redwood apps to adopt? Can we write a codemod for it?
+        - What parts of the design are still TBD?
+
+        Lastly, consider reading some great examples:
+
+        - [Prerender proposal](https://community.redwoodjs.com/t/prerender-proposal/849)
+        - [Optional path parameters](https://github.com/redwoodjs/redwood/issues/2429)
+        - [Multitenant support](https://github.com/redwoodjs/redwood/issues/5821)
+    validations:
+      required: true
+
+  - type: checkboxes
+    attributes:
+      label: Are you interested in working on this?
+      description: >
+        No pressure—this is totally optional!
+        We just want to invite you to contribute to Redwood.
+        If you choose to contribute, the core team will be there to help you the whole way.
+
+
+        If this issue is triaged as lower priority,
+        your willing and ableness to work on it will land it faster than waiting for one of us to pick it up.
+      options:
+        - label: I'm interested in working on this
+
+  - type: markdown
+    attributes:
+      value: >
+        ---
+
+        **About to submit this? Wait!**
+
+
+        Nice work! 👏 Now that you're all done,
+        take a moment to reread your issue's title.
+        Is it descriptive enough?
+        Does it still ring true? 🤔
+        If not, take a moment to rewrite it.