This repository was archived by the owner on Dec 4, 2020. It is now read-only.
Merged
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended the GetPublicData API to support the following measures in addition to rain:
This PR renames all the API methods in this file to indicate the measure they are retrieving although have retained the original
getLive(),get24h(),get60min()andgetTimeforMeasure()for backwards compatibility.This PR also splits the measures into two distinct types "station" and "accessory" - station indicating they come from the original Netatmo weather station and accessory to indicate they come from either the rain or anemometer units. This is important as the data returned in the GetPublicData API is different. e.g:
compared to:
Additionally, the wrapper now includes methods to get a single average value for each measure to ease end users who just want a simple way to get a single value for an area. The only exception to this is the wind/gust angle measures - the data is not clean enough for an average to be useful.
Bumped to version 1.2 to indicate the additions but no API changes.
p.s. HomeAssistant fans - The whole purpose of this PR is so that I can extend the support of the new Netatmo Public Sensor :)