refactor : add component base table data & remove pagination on klaim rw #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ibwedagama
reviewed
Jan 18, 2024
| :button="false" | ||
| placeholder="Masukkan nama akun" | ||
| class="w-[275px] text-gray-500" | ||
| @input="onSearch" |
There was a problem hiding this comment.
hello @marsellavaleria19 is this event used? I cannot find onSeach method on this file 🤔
Comment on lines
+74
to
+81
| computed: { | ||
| query () { | ||
| return { ...this.$store.state['data-table'].query } | ||
| }, | ||
| pagination () { | ||
| return { ...this.$store.state['data-table'].pagination } | ||
| } | ||
| }, |
There was a problem hiding this comment.
hello @marsellavaleria19 if I understand this correctly this BaseTableData component is accessing 'data-table' store (query and pagination property). So every page that uses this component will access the same store? 🤔
if I'm using on 'homepage' page component, and 'about' page component, these two tables will have the same query and pagination data, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Evidence
title: add component base table data & remove pagination on klaim rw
project: Jabar Super Apps
participants: @marsellavaleria19