Gradle 2.9 unsupported error #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brunobowden
commented
Jan 10, 2016
brunobowden
commented
- Throws explanatory error for gradle version 2.9 or later
- Meant to be temporary until Gradle 2.9 regression - Could not find property 'binaries' on project ':base' #568 is fixed
- Fixes Warning that Gradle 2.9 is unsupported #581
brunobowden
force-pushed
the
refactor
branch
3 times, most recently
from
1d08bc7
to
08c76c7
Compare
| // Creates fake tasks to satisfy dependencies for J2objcPlugin.apply(...) | ||
| // Should only be used as an alternative to NativeComplication.apply(...) when | ||
| // the Gradle Version is unsupported and no build can be done. | ||
| void applyForUnsupported() { |
There was a problem hiding this comment.
applyWhenUnsupported I think reads better.
There was a problem hiding this comment.
Duly noted and modified
|
LGTM with comment |
- Throws explanatory error for gradle version 2.9 or later - Meant to be temporary until j2objc-contrib#568 is fixed - Fixes j2objc-contrib#581 (Gradle 2.9 unsupported message) - Fixes j2objc-contrib#585 (Gradle deadlock on unsupported version)
|
I was surprised to see that the checks introduced a deadlock. I'm glad this is sorted now. I'll merge once the CI passes. |
brunobowden
added a commit
that referenced
this pull request
Jan 12, 2016
Gradle 2.9 unsupported error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.