Test-only dependencies; test source translation and execution #489
Conversation
|
@brunobowden ptal. other than documenting dependencies, this is the last thing i will have time for 0.5.0 |
advayDev1
force-pushed
the
testTranslationConfiguration
branch
from
310c9eb
to
55011e4
Compare
| } | ||
| } | ||
|
|
||
| protected void failOnBuildClosureForTests(boolean isTest, Dependency dep) { |
There was a problem hiding this comment.
Stick with the parameter convention: Dependency first, isTest as second parameter.
|
I feel like this should have something in the way of tests. With j2objcTestTranslation, how is it enabled / disabled? I'm thinking of the case where a library may or may not have a test-sources.jar. I'm wondering if it should download and apply the test translation if and only if the test-sources.jar exists. Then if it doesn't exist, that part of the build is just dropped. |
- j2objcTestLinkage links to a j2objc project only for your test source-set - j2objcTestTranslation translates and executes a unit test source jar Fixes j2objc-contrib#465
advayDev1
force-pushed
the
testTranslationConfiguration
branch
from
55011e4
to
b7f7114
Compare
advayDev1
force-pushed
the
testTranslationConfiguration
branch
from
20cdb42
to
06d29a4
Compare
|
@brunobowden ptal.
|
|
LGTM Is there a way to make the code more clear for the tests? I'm wondering if the joiner should be based on the class, so you'd get a result like aEXTbEXTc, or aBASEbBASEc, which makes the context more clear. |
multiProject1 system test also checks that duplicate transitive dependencies function correctly.
advayDev1
force-pushed
the
testTranslationConfiguration
branch
from
06d29a4
to
a3c5b2f
Compare
|
Ok - done |
Test-only dependencies; test source translation and execution
Fixes #465