Separate test translation and building from production library #474

advayDev1 · 2015-09-30T11:21:23Z

No description provided.

brunobowden · 2015-09-30T15:55:16Z

I'll hold off reviewing it until you ask me.

advayDev1 · 2015-09-30T16:36:55Z

yeah hold off for now, i currently have no way of verifying things except pushing to Travis as Xcode 7 is breaking things locally for me

advayDev1 · 2015-10-01T06:32:37Z

The next Travis build should pass. But I'm about to lose internet, so if it turns green, please review. @brunobowden

advayDev1 · 2015-10-01T07:12:26Z

Well Travis (unit tests + system tests do pass). AppVeyor (windows unit tests) aren't. I'm not certain which of your win32-path utils I should use for this error:
https://ci.appveyor.com/project/madvayApiAccess/j2objc-gradle/build/build27.master-yumdtrni

@brunobowden - could you give me a hint there?

brunobowden · 2015-10-01T07:17:33Z

src/test/groovy/com/github/j2objccontrib/j2objcgradle/tasks/TranslateTaskTest.groovy

        IncrementalTaskInputs incrementalTaskInputs = new IncrementalTaskInputs() {
            @Override
            boolean isIncremental() { return false }

            @Override
-            void outOfDate(Action<? super InputFileDetails> outOfDateAction) {}
+            void outOfDate(Action<? super InputFileDetails> outOfDateAction) {
+                proj.files('src/**/*.java').each { final File file ->


The Windows build failed. I think the path may need to be altered to work on Windows. Try and see if the following works:

String filesPath = 'src/**/*.java' if (Utils.isWindows()) { filesPath = 'src\**\*.java' } proj.files(filesPath).each { final File file -> ...

Build failure:
https://ci.appveyor.com/project/madvayApiAccess/j2objc-gradle/build/build27.master-yumdtrni

brunobowden · 2015-10-01T07:42:28Z

src/test/groovy/com/github/j2objccontrib/j2objcgradle/tasks/TranslateTaskTest.groovy

-            void outOfDate(Action<? super InputFileDetails> outOfDateAction) {}
+            void outOfDate(Action<? super InputFileDetails> outOfDateAction) {
+                proj.files(Utils.isWindows() ? 'src\\**\\*.java' : 'src/**/*.java').each {
+                    final File file ->


Can you add warning logs (that show up in the logs for the CI builds on all platforms). Have it show the input to proj.files(...) and the value of the iterator on each file. That'll be fairly verbose but I think that'll help us understand what's going wrong here.

Doesn't work. proj.files is itself failing, not on an individual file (so log never gets hit).
Adding logs to see if the project dir itself exists now - considering the error message

actually i don't see anyway to get logs from our unit tests. what have you used in the past @brunobowden ? they all seem piped away to report files we can't access on CI and neither you nor I have a Windows machine :)

Can you access any logs from the machine?

I remember that Info or Debug logs were suppressed... but terrors and
Warnings came through. So abuse the Error logging for this.

On Thu, Oct 1, 2015, 2:13 AM Advay Mengle [email protected] wrote:

In
src/test/groovy/com/github/j2objccontrib/j2objcgradle/tasks/TranslateTaskTest.groovy
#474 (comment)
:

IncrementalTaskInputs incrementalTaskInputs = new IncrementalTaskInputs() { @Override boolean isIncremental() { return false } @Override

void outOfDate(Action<? super InputFileDetails> outOfDateAction) {}

void outOfDate(Action<? super InputFileDetails> outOfDateAction) {

proj.files(Utils.isWindows() ? 'src\**\*.java' : 'src/**/*.java').each {

final File file ->

actually i don't see anyway to get logs from our unit tests. what have you
used in the past @brunobowden https://github.com/brunobowden ? they all
seem piped away to report files we can't access on CI and neither you nor I
have a Windows machine :)

—
Reply to this email directly or view it on GitHub
https://github.com/j2objc-contrib/j2objc-gradle/pull/474/files#r40893186
.

its not that.

nothing you output during a unit test is ever displayed in the tes ttask

brunobowden · 2015-10-01T08:45:05Z

src/main/groovy/com/github/j2objccontrib/j2objcgradle/tasks/TranslateTask.groovy

+                project.files(getTranslateSourcepaths()),
+                project.files(getGeneratedSourceDirs())
+        ])
+        doTranslate(sourcepathDirs, srcGenTestDir, testTranslateArgs, testSrcFilesChanged)


So this will translate the "Main" code twice? What about duplicating the "Main" code and only translating the "Test" code in the second step? This would reduce the translation but where does this break?

no. remember that sourcepath is NOT the list of things being translated (except when using --build-closure and the files in that directory are used transitively).

the list of files translated is testSrcFilesChanged in that call - which includes no main files

Ahh, makes sense. Got it.

brunobowden · 2015-10-01T08:55:28Z

I'm not sure what's going on with the Windows build but I believe my instinct is correct about the case. It would be helpful if you could add enough logging so that we can see what it's doing.

brunobowden · 2015-10-01T09:06:13Z

systemTests/run-all.sh

@@ -24,7 +24,11 @@ function runTest {
    pushd $TEST_DIR
    ./gradlew wrapper
    ./gradlew clean
-    ./gradlew build
+    # If we fail, try again with lots of logging.
+    ./gradlew build || echo FAIL_LOG_FAIL_LOG_FAIL_LOG_FAIL_LOG && ./gradlew build --debug --stacktrace


Wrap with "****" as scanning the left hand side of a block of text, it's easier to spot this:

**** FAIL_LOG_FAIL_LOG_FAIL_LOG_FAIL_LOG ****

Do that you if you can quote it... if it causes hassle for the script then drop the suggestion.

used underscores instead of starts for that reason

advayDev1 · 2015-10-01T09:46:16Z

@brunobowden - windows fixed. there were 2 bugs:
0. Misunderstanding of project.files(...) - it doesn't accept globs, just arrays of individually named files.

MockProjectExec's handling of multiple arguments to project.files

nothing about windows!

Fixes j2objc-contrib#112

advayDev1 · 2015-10-01T20:07:40Z

ptal @brunobowden - i think this is good to go

brunobowden · 2015-10-01T21:21:16Z

src/test/groovy/com/github/j2objccontrib/j2objcgradle/tasks/MockProjectExec.groovy

                        // files(ArrayList) possibly, so cast ArrayList to Object[]
                        return metaMethod?.invoke(delegate, [(Object[]) args.first()] as Object[])
+                    } else {
+                        return metaMethod?.invoke(delegate, [args] as Object[])


Does metaMethod?.invoke(delegate, [args] as Object[]) work for the args.size() == 1 case?

It shouldn't...
L96 is equivalent to invoke(delegate, [[args[0][0], args[0][1], args[0][2]]])
L98 is equivalent to invoke(delegate, [[args[0], args[1], args[2]]])

brunobowden · 2015-10-01T21:22:00Z

LGTM

See if you can simplify the line within MockProjectExec. Either way, we're good to go.

Separate test translation and building from production library

advayDev1 force-pushed the testSep branch 2 times, most recently from df75fff to 714e8b7 Compare September 30, 2015 11:45

advayDev1 force-pushed the testSep branch 2 times, most recently from b14f552 to e17c206 Compare September 30, 2015 16:59

advayDev1 mentioned this pull request Oct 1, 2015

Release 0.4.3 #473

Closed

advayDev1 force-pushed the testSep branch from e17c206 to baa346b Compare October 1, 2015 06:31

advayDev1 changed the title ~~WIP: Separate test translation and building from production library~~ Separate test translation and building from production library Oct 1, 2015

advayDev1 assigned brunobowden Oct 1, 2015