-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow mapping of Java source files. #455
Conversation
@advayDev1 whar is this good for compared with |
I'm currently using it for the following: translateSourcepaths works only if I was using this library in exactly one other project AND i was willing to use --build-closure. Instead I chose to build this third-party library using the new |
@@ -45,7 +45,7 @@ class CycleFinderTask extends DefaultTask { | |||
if (J2objcConfig.from(project).translatePattern != null) { | |||
ret = allFiles.matching(J2objcConfig.from(project).translatePattern) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change ret => result, I think it's more legible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it seems like ret
is a convention so shall we stick with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep it is
LGTM Yet another example of why cycleFinder and translate should have a shared base class ;-) |
Allow mapping of Java source files.
No description provided.