Default to only modern architectures #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Adding an unrecognized new architecture here will fail. | ||
| * By default, only common modern iOS architectures will be built: | ||
| * ios_arm64, ios_armv7, ios_x86_64. You may choose to add any of the remaining | ||
| * entries from NativeCompilation.ALL_SUPPORTED_ARCHS to support all possible |
There was a problem hiding this comment.
It would be better to enumerate the other alternatives as well:
...
entries from NativeCompilation.ALL_SUPPORTED_ARCHS (ios_i386 and ios_armv7s)
to support all possible iOS architectures. Listing any new architectures outside of
ALL_SUPPORTED_ARCHS will fail the build.
|
@advayDev1 - I agree this is much better. Thanks for the suggestion. |
|
LGTM |
|
You'll just need to fix up the unit tests... you can copy some of the changes from my PR. |
|
LGTM |
|
@advayDev1 You should add the overview comment that @brunobowden had in his request. It shows which phone type has which architecture. |
|
@confile - done |
advayDev1
added a commit
that referenced
this pull request
Sep 6, 2015
Default to only modern architectures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better fix for #443 (compare vs. #444).
I think this is much simpler, makes regular users faster, and does not take away power users' ability to use all architectures.
cc: @confile