Guava 19.0

[advayDev1]

No description provided.

[brunobowden]

This is showing a merge conflict - can you rebase it?

[advayDev1]

Don't review this yet @brunobowden - this is just a demo for the j2objc folks of the build break on 19.0rc1

[brunobowden]

I'm just excited to see the progress ;-)

On Fri, Aug 28, 2015 at 9:41 AM Advay Mengle [email protected]
wrote:

Don't review this yet @brunobowden https://github.com/brunobowden -
this is just a demo for the j2objc folks of the build break on 19.0rc1

—
Reply to this email directly or view it on GitHub
#434 (comment)
.

[brunobowden]

cc @tomball, @kstanger

[brunobowden]

Version "19.0-rc2" was published the end of September.

@advayDev1 - can you please confirm whether this issue still exists. If so, then we should coordinate with @tomball and @kstanger to see about getting this resolved.

[advayDev1]

My own tests showed things are fine. I still don't think we should submit anything until Guava is released.

[brunobowden]

@advayDev1 - Aug 28th comment, you mentioned a build break. Is that now fixed? Is it possible to get a clean build in this PR? It would be nice to confirm that before 19.0 is released.

[advayDev1]

That build break was fixed by @kstanger in google/j2objc@0c2c7b1

[brunobowden]

From that PR, it looks as though this was included within 0.9.8.2.1? If you update this PR with that change, will it now work? I understand about delaying merge until the official 19.0 release.

[brunobowden]

@advayDev1 - do you want to keep this open or close this?

[advayDev1]

Since they released full 19.0, I updated the config.
If it works, let's merge, if not, I won't have time to debug right now.

[brunobowden]

LGTM assuming that the build works

[brunobowden]

CI passed. Good news. Please merge at your leisure.

[advayDev1]

heh, pleasantly surprised.