Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-project system test. #411

Merged
merged 1 commit into from
Aug 26, 2015
Merged

Multi-project system test. #411

merged 1 commit into from
Aug 26, 2015

Conversation

advayDev1
Copy link
Contributor

@advayDev1 advayDev1 added this to the 0.5 Release milestone Aug 24, 2015
This was referenced Aug 24, 2015
Closed
Closed
@brunobowden
Copy link
Contributor

@advayDev1 - I'll review this later tonight

@advayDev1
Copy link
Contributor Author

SG. I'm about to PR Automatic Dependency resolution which extends this PR.

@brunobowden
Copy link
Contributor

I noticed that commonly a http://remote/lib.jar will have the library
available at http://remote/lib-sources.jar. My hope is that for most common
libraries, you only need to add the compile or testCompile and
everything works. Some cases might need more configuration, but then you
can manually download and specify the sources jar.

On Tue, Aug 25, 2015 at 4:54 PM Advay Mengle [email protected]
wrote:

SG. I'm about to PR Automatic Dependency resolution which extends this PR.

—
Reply to this email directly or view it on GitHub
#411 (comment)
.

@advayDev1 advayDev1 mentioned this pull request Aug 26, 2015
Merged
@advayDev1
Copy link
Contributor Author

All done at #420

brunobowden
brunobowden reviewed Aug 26, 2015
View reviewed changes
systemTests/multiProject1/build.gradle
jcenter()
}
dependencies {
classpath fileTree(dir: '../../build/libs', include: ['*.jar'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this because it's the build/libs directory from off ROOT_DIR? Please add explanation for ../../ parent directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is the output of the plugin build. noted

@advayDev1 advayDev1 force-pushed the systemTestsBeachHead branch 2 times, most recently from e070650 to 157998a Compare August 26, 2015 07:36
@advayDev1
Copy link
Contributor Author

ptal @brunobowden . repushed and passing.

brunobowden
brunobowden reviewed Aug 26, 2015
View reviewed changes
systemTests/multiProject1/base/build.gradle
}

dependencies {
compile 'com.google.guava:guava:17.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add note that you're intentionally adding guava to test the e2e compile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@brunobowden
Copy link
Contributor

LGTM - though see if you can think of a better name than multiProject1

@advayDev1
Copy link
Contributor Author

That is quite intentional. I think we'll have multiProject2... N
EDIT: Although I added comments in run-all saying what each test is testing.

advayDev1 added a commit that referenced this pull request Aug 26, 2015
@advayDev1
Merge pull request #411 from madvay/systemTestsBeachHead
1223b5c 
Multi-project system test.
@advayDev1 advayDev1 merged commit 1223b5c into j2objc-contrib:master Aug 26, 2015
@advayDev1 advayDev1 deleted the systemTestsBeachHead branch August 26, 2015 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cat:testing
Projects
None yet
Milestone
0.5 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@advayDev1 @brunobowden