Our first system test! #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advayDev1
force-pushed
the
systemTestsBeachHead
branch
2 times, most recently
from
decd9d3
to
2e7817a
Compare
|
Works locally, works on Travis: ptal @brunobowden |
| !local.properties | ||
| # Generated by prep.sh | ||
| common/local.properties | ||
| localJ2objcDist/ |
There was a problem hiding this comment.
What are these two ignore lines for?
There was a problem hiding this comment.
As it says, those files/directories are generated by prep.sh
|
LGTM You should also see if you can validate a build error. E.g. by posting a PR that breaks the Hello World... both the 'java' build and then translated, e.g. using some OCNI junk. |
|
That's a really good point. Will do |
This can be improved a lot, but we have to capture a beach-head first.
advayDev1
force-pushed
the
systemTestsBeachHead
branch
from
2e7817a
to
077fee9
Compare
|
Errors correctly fail: merging |
This was referenced Aug 24, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be improved a lot, but we have to capture a beach-head first.