Moved from using RETURN_GENERATED_KEYS to named columns #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2018
|
Good stuff!! Again awesome tests dude. Thanks much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statement.RETURN_GENERATED_KEYSis a poorly defined standard. Different JDBC drivers interpret it differently so its behaviour can, and does, differ.The best example of this is PostgreSQL and modern H2 drivers where this flag will still return rows which have a column generated, but the result set contains all columns. Meanwhile over in SQL Server, it returns a pseudocolumn and not a real column so even filtering the result set will not work there.
So instead we explicitly declare which column we want which works a lot better for compatibility between drivers.
On the JDBC side: j256/ormlite-jdbc#39.