Skip to content

Reapply "Reject unsupported YAML tags in check-yaml (#2656)" - #2672

Merged
j178 merged 3 commits into
masterfrom
revert
Sep 1, 2026
Merged

j178 merged 3 commits into
masterfrom
revert

Conversation

@j178

@j178 j178 commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Copilot AI lite review requested due to automatic review settings September 1, 2026 06:30
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-01T06:33:12.134591Z 628fff4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 628fff4357

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Cargo.toml
Comment thread crates/prek/src/hooks/pre_commit_hooks/check_yaml.rs
@j178 j178 changed the title revert Reapply "Reject unsupported YAML tags in check-yaml (#2656)" Sep 1, 2026
@j178 j178 added the internal Internal changes label Sep 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new inline snapshot test likely fails due to a trailing newline mismatch, and the repo-wide --unsafe hook configuration weakens YAML validation more broadly than necessary.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR reverts the repository back to version 0.5.1 and re-applies stricter check-yaml behavior by rejecting unsupported YAML tags during load, while documenting/using --unsafe as an escape hatch for tag-heavy YAML (notably mkdocs.yml).

Changes:

  • Revert version references from 0.5.2 back to 0.5.1 across Rust/Python metadata, lockfiles, docs, and issue templates.
  • Re-enable unsupported YAML tag rejection in check-yaml and add a regression test for unknown tags requiring --unsafe.
  • Update repo hook config to run check-yaml with --unsafe.
File summaries
File Description
uv.lock Reverts locked package version to 0.5.1.
README.md Updates installer URLs to v0.5.1.
pyproject.toml Reverts Python project version to 0.5.1.
prek.toml Enables check-yaml with --unsafe in the repo hook config.
docs/integrations.md Updates container image examples to 0.5.1 tags.
crates/prek/src/hooks/pre_commit_hooks/check_yaml.rs Re-enables unsupported tag rejection and adds a test covering unsafe vs load behavior.
CHANGELOG.md Removes 0.5.2 entry, leaving 0.5.1 as the latest.
Cargo.toml Reverts workspace/package versions to 0.5.1.
Cargo.lock Reverts crate versions to 0.5.1.
.github/ISSUE_TEMPLATE/bug_report.yaml Updates “current version” label to 0.5.1.
Review details
  • Files reviewed: 8/10 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread prek.toml
Comment thread crates/prek/src/hooks/pre_commit_hooks/check_yaml.rs
@codecov

codecov Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.10%. Comparing base (ed225b1) to head (628fff4).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2672   +/-   ##
=======================================
  Coverage   94.10%   94.10%           
=======================================
  Files         141      141           
  Lines       30035    30043    +8     
=======================================
+ Hits        28265    28273    +8     
  Misses       1770     1770           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@j178
j178 merged commit edf43d5 into master Sep 1, 2026
46 checks passed
@j178
j178 deleted the revert branch September 1, 2026 06:36

This branch was previously deployed

1 inactive deployment
release — 628fff43 Deployed Sep 1, 2026 by j178 via build-docker / Build Alpine Docker image #6346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants