Repository navigation
Conversation
j178
commented
Sep 1, 2026
- Revert "Bump version to 0.5.2 (Bump version to 0.5.2 #2671)"
- Revert "Revert unsupported YAML tag rejection in check-yaml (Revert unsupported YAML tag rejection in check-yaml #2670)"
- Reapply "Reject unsupported YAML tags in check-yaml (Reject unsupported YAML tags in check-yaml #2656)"
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 628fff4357
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
🟡 Changes recommended
The new inline snapshot test likely fails due to a trailing newline mismatch, and the repo-wide --unsafe hook configuration weakens YAML validation more broadly than necessary.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR reverts the repository back to version 0.5.1 and re-applies stricter check-yaml behavior by rejecting unsupported YAML tags during load, while documenting/using --unsafe as an escape hatch for tag-heavy YAML (notably mkdocs.yml).
Changes:
- Revert version references from
0.5.2back to0.5.1across Rust/Python metadata, lockfiles, docs, and issue templates. - Re-enable unsupported YAML tag rejection in
check-yamland add a regression test for unknown tags requiring--unsafe. - Update repo hook config to run
check-yamlwith--unsafe.
File summaries
| File | Description |
|---|---|
uv.lock |
Reverts locked package version to 0.5.1. |
README.md |
Updates installer URLs to v0.5.1. |
pyproject.toml |
Reverts Python project version to 0.5.1. |
prek.toml |
Enables check-yaml with --unsafe in the repo hook config. |
docs/integrations.md |
Updates container image examples to 0.5.1 tags. |
crates/prek/src/hooks/pre_commit_hooks/check_yaml.rs |
Re-enables unsupported tag rejection and adds a test covering unsafe vs load behavior. |
CHANGELOG.md |
Removes 0.5.2 entry, leaving 0.5.1 as the latest. |
Cargo.toml |
Reverts workspace/package versions to 0.5.1. |
Cargo.lock |
Reverts crate versions to 0.5.1. |
.github/ISSUE_TEMPLATE/bug_report.yaml |
Updates “current version” label to 0.5.1. |
Review details
- Files reviewed: 8/10 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2672 +/- ##
=======================================
Coverage 94.10% 94.10%
=======================================
Files 141 141
Lines 30035 30043 +8
=======================================
+ Hits 28265 28273 +8
Misses 1770 1770 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|