Preserve system download policy when applying metadata - #2395
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2395 +/- ##
==========================================
+ Coverage 93.38% 93.47% +0.09%
==========================================
Files 129 130 +1
Lines 27637 28035 +398
==========================================
+ Hits 25810 26207 +397
- Misses 1827 1828 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
📦 Cargo Bloat ComparisonBinary size change: +0.68% (29.2 MiB → 29.4 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
⚡️ Hyperfine BenchmarksSummary: 0 regressions, 1 improvements above the 10% threshold. Environment
CLI CommandsBenchmarking basic commands in the main repo:
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base --version |
2.3 ± 0.1 | 2.2 | 2.8 | 1.02 ± 0.05 |
prek-head --version |
2.2 ± 0.1 | 2.1 | 2.4 | 1.00 |
prek list
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base list |
9.6 ± 0.2 | 9.3 | 10.6 | 1.03 ± 0.03 |
prek-head list |
9.4 ± 0.1 | 9.1 | 9.9 | 1.00 |
prek validate-config .pre-commit-config.yaml
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base validate-config .pre-commit-config.yaml |
3.5 ± 0.1 | 3.3 | 3.9 | 1.08 ± 0.07 |
prek-head validate-config .pre-commit-config.yaml |
3.2 ± 0.2 | 3.0 | 4.5 | 1.00 |
prek sample-config
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base sample-config |
2.6 ± 0.1 | 2.5 | 2.9 | 1.08 ± 0.03 |
prek-head sample-config |
2.4 ± 0.0 | 2.3 | 2.5 | 1.00 |
Cold vs Warm Runs
Comparing first run (cold) vs subsequent runs (warm cache):
prek run --all-files (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
67.8 ± 1.2 | 66.5 | 70.0 | 1.01 ± 0.02 |
prek-head run --all-files |
67.1 ± 0.9 | 65.5 | 68.5 | 1.00 |
prek run --all-files (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
67.5 ± 1.2 | 65.1 | 69.6 | 1.00 ± 0.03 |
prek-head run --all-files |
67.3 ± 1.3 | 65.5 | 70.9 | 1.00 |
Full Hook Suite
Running the builtin hook suite on the benchmark workspace:
prek run --all-files (full builtin hook suite)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
66.8 ± 1.0 | 64.3 | 68.5 | 1.00 |
prek-head run --all-files |
67.2 ± 1.0 | 65.7 | 70.0 | 1.01 ± 0.02 |
Individual Hook Performance
Benchmarking each hook individually on the test repo:
prek run trailing-whitespace --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run trailing-whitespace --all-files |
20.5 ± 0.7 | 19.7 | 23.4 | 1.01 ± 0.04 |
prek-head run trailing-whitespace --all-files |
20.2 ± 0.5 | 19.5 | 21.7 | 1.00 |
prek run end-of-file-fixer --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run end-of-file-fixer --all-files |
19.6 ± 0.4 | 19.0 | 20.6 | 1.01 ± 0.03 |
prek-head run end-of-file-fixer --all-files |
19.4 ± 0.3 | 18.7 | 20.2 | 1.00 |
prek run check-json --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-json --all-files |
8.2 ± 0.3 | 7.8 | 8.9 | 1.05 ± 0.05 |
prek-head run check-json --all-files |
7.8 ± 0.3 | 7.4 | 8.4 | 1.00 |
prek run check-yaml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-yaml --all-files |
7.8 ± 0.1 | 7.6 | 8.1 | 1.04 ± 0.02 |
prek-head run check-yaml --all-files |
7.5 ± 0.1 | 7.2 | 7.8 | 1.00 |
prek run check-toml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-toml --all-files |
8.6 ± 1.4 | 7.5 | 12.4 | 1.13 ± 0.18 |
prek-head run check-toml --all-files |
7.6 ± 0.3 | 7.2 | 8.9 | 1.00 |
✅ Performance improvement for prek run check-toml --all-files: 11.4100% faster
prek run check-xml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-xml --all-files |
7.8 ± 0.4 | 7.3 | 8.7 | 1.04 ± 0.07 |
prek-head run check-xml --all-files |
7.5 ± 0.4 | 7.1 | 8.9 | 1.00 |
prek run detect-private-key --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run detect-private-key --all-files |
11.4 ± 0.6 | 10.5 | 12.9 | 1.03 ± 0.08 |
prek-head run detect-private-key --all-files |
11.1 ± 0.6 | 10.2 | 13.6 | 1.00 |
prek run fix-byte-order-marker --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run fix-byte-order-marker --all-files |
18.5 ± 0.7 | 17.3 | 19.9 | 1.00 |
prek-head run fix-byte-order-marker --all-files |
18.8 ± 0.7 | 17.7 | 20.2 | 1.01 ± 0.05 |
Installation Performance
Benchmarking hook installation (fast path hooks skip Python setup):
prek install-hooks (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
4.7 ± 0.1 | 4.6 | 4.8 | 1.02 ± 0.02 |
prek-head install-hooks |
4.6 ± 0.0 | 4.6 | 4.7 | 1.00 |
prek install-hooks (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
4.7 ± 0.1 | 4.6 | 4.8 | 1.03 ± 0.03 |
prek-head install-hooks |
4.6 ± 0.1 | 4.5 | 4.7 | 1.00 |
File Filtering/Scoping Performance
Testing different file selection modes:
prek run (staged files only)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run |
36.7 ± 0.6 | 36.1 | 38.1 | 1.01 ± 0.02 |
prek-head run |
36.3 ± 0.6 | 35.7 | 38.0 | 1.00 |
prek run --files '*.json' (specific file type)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --files '*.json' |
8.3 ± 0.1 | 8.2 | 8.7 | 1.04 ± 0.02 |
prek-head run --files '*.json' |
8.0 ± 0.1 | 7.9 | 8.2 | 1.00 |
Workspace Discovery & Initialization
Benchmarking hook discovery and initialization overhead:
prek run --dry-run --all-files (measures init overhead)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --dry-run --all-files |
7.1 ± 0.1 | 7.0 | 7.3 | 1.04 ± 0.02 |
prek-head run --dry-run --all-files |
6.8 ± 0.1 | 6.7 | 7.0 | 1.00 |
Meta Hooks Performance
Benchmarking meta hooks separately:
prek run check-hooks-apply --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-hooks-apply --all-files |
12.2 ± 0.1 | 12.0 | 12.4 | 1.01 ± 0.02 |
prek-head run check-hooks-apply --all-files |
12.2 ± 0.3 | 11.9 | 12.7 | 1.00 |
prek run check-useless-excludes --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-useless-excludes --all-files |
10.9 ± 0.1 | 10.7 | 11.2 | 1.01 ± 0.02 |
prek-head run check-useless-excludes --all-files |
10.7 ± 0.1 | 10.5 | 10.9 | 1.00 |
prek run identity --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run identity --all-files |
10.2 ± 0.1 | 10.0 | 10.4 | 1.03 ± 0.01 |
prek-head run identity --all-files |
9.9 ± 0.1 | 9.8 | 10.1 | 1.00 |
Closes #2392