Skip to content

Honor filenames in builtin hook entry and args - #2389

Merged
j178 merged 1 commit into
masterfrom
hook-arg-files
Jul 22, 2026
Merged

Honor filenames in builtin hook entry and args#2389
j178 merged 1 commit into
masterfrom
hook-arg-files

Conversation

@j178

@j178 j178 commented Jul 22, 2026

Copy link
Copy Markdown
Owner

Honor filenames embedded in entry and args for builtin and fast-path pre-commit hooks.

Configured filenames run serially before runner-selected filenames, preventing duplicate modifying hooks from writing the same file concurrently.

Copilot AI review requested due to automatic review settings July 22, 2026 18:27
@j178 j178 added the bug Something isn't working label Jul 22, 2026 — with ChatGPT Codex Connector

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@j178
j178 merged commit 6c89849 into master Jul 22, 2026
33 checks passed
@j178
j178 deleted the hook-arg-files branch July 22, 2026 18:34
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.21875% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.39%. Comparing base (28bc3f0) to head (d9a6df6).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
crates/prek/src/hooks/pre_commit_hooks/mod.rs 98.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2389      +/-   ##
==========================================
+ Coverage   93.37%   93.39%   +0.01%     
==========================================
  Files         129      129              
  Lines       27548    27642      +94     
==========================================
+ Hits        25723    25816      +93     
- Misses       1825     1826       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants