Skip to content

Preserve hook output order with a shared pipe - #2385

Merged
j178 merged 1 commit into
masterfrom
output-order
Jul 22, 2026
Merged

Preserve hook output order with a shared pipe#2385
j178 merged 1 commit into
masterfrom
output-order

Conversation

@j178

@j178 j178 commented Jul 22, 2026

Copy link
Copy Markdown
Owner

Fix hook output ordering by capturing stdout and stderr through a shared pipe before spawning the process. Centralize merged batch output handling across language backends.

Closes #2382

Copilot AI review requested due to automatic review settings July 22, 2026 15:40
@j178 j178 added the bug Something isn't working label Jul 22, 2026
Copilot AI reviewed Jul 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@prek-ci-bot

prek-ci-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

📦 Cargo Bloat Comparison

Binary size change: -0.34% (29.2 MiB → 29.1 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.1%   2.3% 332.0KiB        aws_lc_sys aws_lc_0_42_0_aes_gcm_encrypt_avx512
 1.1%   2.3% 332.0KiB        aws_lc_sys aws_lc_0_42_0_aes_gcm_decrypt_avx512
 0.2%   0.5%  65.2KiB              prek <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  58.5KiB              prek <<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.2%   0.3%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.3%  48.5KiB              prek prek::run::{closure#0}
 0.1%   0.3%  40.9KiB              prek prek::cli::run::run::run::{closure#0}
 0.1%   0.2%  33.6KiB              prek <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  30.1KiB     granit_parser <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
 0.1%   0.2%  28.9KiB    cargo_metadata <&mut serde_json::de::Deserializer<serde_json::read::StrRead> as serde_core::de::Deserializer>::deserialize_struct::<<cargo_metadata::Package as serde_core::de::Deserialize>::deserialize::__Visitor>
 0.1%   0.2%  28.4KiB              prek <<prek::config::RemoteHook as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_42_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_42_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.5KiB              prek prek::cli::try_repo::try_repo::{closure#0}
 0.1%   0.2%  25.6KiB              prek <<prek::config::LocalHook as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  25.5KiB              prek <prek::languages::bun::bun::Bun as prek::languages::LanguageBackend>::install::{closure#0}
 0.1%   0.2%  25.0KiB              prek <<prek::config::UpdateOptions as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  24.9KiB               xml <xml::reader::parser::PullParser>::dispatch_token
 0.1%   0.2%  24.4KiB              prek <prek::languages::node::installer::NodeInstaller>::install::{closure#0}
 0.1%   0.2%  24.0KiB     granit_parser <granit_parser::scanner::Scanner<serde_saphyr::de::buffered_input::ReaderInput>>::fetch_more_tokens
42.2%  88.2%  12.3MiB                   And 25791 smaller methods. Use -n N to show more.
47.9% 100.0%  14.0MiB                   .text section size, the file size is 29.1MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.1%   2.3% 332.0KiB        aws_lc_sys aws_lc_0_42_0_aes_gcm_encrypt_avx512
 1.1%   2.3% 332.0KiB        aws_lc_sys aws_lc_0_42_0_aes_gcm_decrypt_avx512
 0.3%   0.6%  79.3KiB              prek <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  58.3KiB              prek <<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.2%   0.3%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.1%   0.3%  39.7KiB              prek prek::cli::run::run::run::{closure#0}
 0.1%   0.3%  38.7KiB              prek prek::run::{closure#0}
 0.1%   0.2%  34.3KiB              prek <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  30.1KiB     granit_parser <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
 0.1%   0.2%  29.4KiB              prek <<prek::config::RemoteHook as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  28.6KiB    cargo_metadata <&mut serde_json::de::Deserializer<serde_json::read::StrRead> as serde_core::de::Deserializer>::deserialize_struct::<<cargo_metadata::Package as serde_core::de::Deserialize>::deserialize::__Visitor>
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_42_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_42_0_edwards25519_scalarmuldouble
 0.1%   0.2%  25.8KiB              prek prek::cli::try_repo::try_repo::{closure#0}
 0.1%   0.2%  25.3KiB              prek <<prek::config::LocalHook as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  25.2KiB              prek <<prek::config::UpdateOptions as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  24.9KiB               xml <xml::reader::parser::PullParser>::dispatch_token
 0.1%   0.2%  24.4KiB              prek <prek::languages::node::installer::NodeInstaller>::install::{closure#0}
 0.1%   0.2%  24.0KiB     granit_parser <granit_parser::scanner::Scanner<serde_saphyr::de::buffered_input::ReaderInput>>::fetch_more_tokens
 0.1%   0.2%  22.8KiB              prek prek::archive::unzip::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
42.3%  88.2%  12.3MiB                   And 25798 smaller methods. Use -n N to show more.
47.9% 100.0%  14.0MiB                   .text section size, the file size is 29.2MiB

@prek-ci-bot

prek-ci-bot Bot commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 1 improvements above the 10% threshold.

Environment
  • OS: Linux 6.17.0-1020-azure
  • CPU: 4 cores
  • prek version: prek 0.4.10+24 (8344be1 2026-07-22)
  • Rust version: rustc 1.97.1 (8bab26f4f 2026-07-14)
  • Hyperfine version: hyperfine 1.20.0
CLI Commands

Benchmarking basic commands in the main repo:

prek --version

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base --version 2.3 ± 0.1 2.2 2.6 1.08 ± 0.04
prek-head --version 2.1 ± 0.1 2.0 2.5 1.00

prek list

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base list 9.3 ± 0.1 9.1 9.8 1.03 ± 0.02
prek-head list 9.1 ± 0.1 8.9 9.5 1.00

prek validate-config .pre-commit-config.yaml

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base validate-config .pre-commit-config.yaml 3.3 ± 0.1 3.2 3.5 1.09 ± 0.03
prek-head validate-config .pre-commit-config.yaml 3.0 ± 0.1 2.9 3.2 1.00

prek sample-config

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base sample-config 2.6 ± 0.1 2.5 2.7 1.05 ± 0.03
prek-head sample-config 2.5 ± 0.1 2.3 2.6 1.00
Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

prek run --all-files (cold - no cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 74.7 ± 2.6 71.0 79.3 1.03 ± 0.04
prek-head run --all-files 72.5 ± 1.9 70.1 74.8 1.00

prek run --all-files (warm - with cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 72.9 ± 2.5 69.3 76.6 1.02 ± 0.05
prek-head run --all-files 71.9 ± 2.3 68.7 76.3 1.00
Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

prek run --all-files (full builtin hook suite)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 72.7 ± 2.4 67.7 79.4 1.00
prek-head run --all-files 73.4 ± 6.3 68.6 114.3 1.01 ± 0.09
Individual Hook Performance

Benchmarking each hook individually on the test repo:

prek run trailing-whitespace --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run trailing-whitespace --all-files 19.4 ± 0.5 18.8 20.6 1.00 ± 0.04
prek-head run trailing-whitespace --all-files 19.3 ± 0.5 18.5 20.8 1.00

prek run end-of-file-fixer --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run end-of-file-fixer --all-files 24.9 ± 1.6 22.9 28.0 1.01 ± 0.09
prek-head run end-of-file-fixer --all-files 24.6 ± 1.7 22.8 28.2 1.00

prek run check-json --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-json --all-files 7.8 ± 0.3 7.2 8.5 1.03 ± 0.06
prek-head run check-json --all-files 7.6 ± 0.3 7.0 8.2 1.00

prek run check-yaml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-yaml --all-files 7.6 ± 0.1 7.4 7.9 1.02 ± 0.03
prek-head run check-yaml --all-files 7.4 ± 0.2 7.2 7.9 1.00

prek run check-toml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-toml --all-files 7.7 ± 0.3 7.4 8.5 1.02 ± 0.05
prek-head run check-toml --all-files 7.6 ± 0.3 7.1 8.3 1.00

prek run check-xml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-xml --all-files 7.6 ± 0.4 7.2 8.8 1.02 ± 0.08
prek-head run check-xml --all-files 7.4 ± 0.4 7.0 8.5 1.00

prek run detect-private-key --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run detect-private-key --all-files 13.4 ± 1.0 11.7 15.3 1.03 ± 0.11
prek-head run detect-private-key --all-files 13.1 ± 1.0 12.0 15.7 1.00

prek run fix-byte-order-marker --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run fix-byte-order-marker --all-files 17.5 ± 0.7 16.6 19.2 1.01 ± 0.06
prek-head run fix-byte-order-marker --all-files 17.3 ± 0.7 16.0 18.6 1.00
Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

prek install-hooks (cold - no cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base install-hooks 4.6 ± 0.2 4.5 5.0 1.06 ± 0.05
prek-head install-hooks 4.4 ± 0.0 4.3 4.4 1.00

prek install-hooks (warm - with cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base install-hooks 4.6 ± 0.0 4.6 4.6 1.05 ± 0.01
prek-head install-hooks 4.4 ± 0.1 4.3 4.5 1.00
File Filtering/Scoping Performance

Testing different file selection modes:

prek run (staged files only)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run 36.6 ± 0.7 35.4 38.0 1.00
prek-head run 37.1 ± 1.1 35.5 38.7 1.01 ± 0.04

prek run --files '*.json' (specific file type)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --files '*.json' 8.0 ± 0.1 7.8 8.2 1.02 ± 0.02
prek-head run --files '*.json' 7.8 ± 0.1 7.6 8.1 1.00
Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

prek run --dry-run --all-files (measures init overhead)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --dry-run --all-files 7.2 ± 0.2 6.8 7.7 1.08 ± 0.04
prek-head run --dry-run --all-files 6.7 ± 0.1 6.5 7.0 1.00
Meta Hooks Performance

Benchmarking meta hooks separately:

prek run check-hooks-apply --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-hooks-apply --all-files 12.0 ± 0.2 11.8 12.4 1.08 ± 0.08
prek-head run check-hooks-apply --all-files 11.1 ± 0.8 10.2 12.2 1.00

prek run check-useless-excludes --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-useless-excludes --all-files 10.7 ± 0.1 10.6 10.9 1.02 ± 0.02
prek-head run check-useless-excludes --all-files 10.5 ± 0.1 10.3 10.7 1.00

prek run identity --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run identity --all-files 38.2 ± 90.5 9.9 358.9 3.81 ± 9.03
prek-head run identity --all-files 10.0 ± 0.5 9.6 11.1 1.00

✅ Performance improvement for prek run identity --all-files: 73.7900% faster

Copilot AI review requested due to automatic review settings July 22, 2026 15:55
Copilot AI reviewed Jul 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings July 22, 2026 16:08
Copilot AI reviewed Jul 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@j178
j178 merged commit d91c6f3 into master Jul 22, 2026
34 checks passed
@j178
j178 deleted the output-order branch July 22, 2026 16:16
@j178 j178 mentioned this pull request Jul 22, 2026
Merged
j178 added a commit that referenced this pull request Jul 22, 2026
@j178
Stabilize the Docker image output snapshot (#2386)
6d63339 
Suppress Gitleaks banner and status logs in the Docker image test so
Docker's stdout/stderr interleaving cannot make the snapshot flaky after
#2385.
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.73684% with 7 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@92bdbf2). Learn more about missing BASE report.
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
crates/prek/src/process.rs 88.70% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #2385   +/-   ##
=========================================
  Coverage          ?   93.37%           
=========================================
  Files             ?      129           
  Lines             ?    27513           
  Branches          ?        0           
=========================================
  Hits              ?    25689           
  Misses            ?     1824           
  Partials          ?        0

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BrewTestBot BrewTestBot mentioned this pull request Jul 24, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hook stderr/stdout ordering differs from original pre-commit

2 participants

@j178