Merged
Conversation
Implement Swift language support for prek: - Query swift executable and parse version from `swift --version` - Handle both macOS (Apple Swift) and Linux version formats - Normalize versions without patch component (e.g., "6.1" -> "6.1.0") - Handle pre-release versions (e.g., "6.2-dev") - Build Package.swift repos with `swift build -c release` - Use `swift build --show-bin-path` to resolve target-specific bin directory - Add built binaries to PATH when running hooks - Health check verifies swift executable still exists Include unit tests for version parsing covering: - macOS format with swift-driver prefix - Linux format - Multiline output handling - Versions without patch component - Development/nightly versions - Invalid input handling
efe2104 to
44dbd07
Compare
📦 Cargo Bloat ComparisonBinary size change: +0.00% (22.8 MiB → 22.8 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1463 +/- ##
==========================================
+ Coverage 90.99% 91.06% +0.06%
==========================================
Files 86 87 +1
Lines 18182 18386 +204
==========================================
+ Hits 16545 16743 +198
- Misses 1637 1643 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
980ea36 to
32b7b4d
Compare
- pin Swift version in env to keep CI deterministic\n- use SwiftyLab/setup-swift on Windows where swift-actions fails\n- install Swift on macOS and reset TOOLCHAINS back to Xcode\n- force CC/CXX/SDKROOT from Xcode so Ruby native gems compile\n\nThis keeps Swift hooks available while restoring Xcode's clang/SDK,\nwhich avoids msgpack native extension failures on macOS.
d6ed540 to
f739eca
Compare
Owner
|
Thanks for the great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46