RTPIPv6Address::GetAddressString - Enclose the address in square brackets and use a colon to separate the port #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function allows you to change the data that will be sent out (e.g. for encryption). It could also be used to disable sending RTCP packets.
Added OnValidatedRTPPacket to RTPSession and RTPSources, allowing you to process a packet as soon as it is linked to an RTPSourceData instance. This way you can avoid the GotoFirst/GotoNext iteration over the sources. An OnChangeIncomingData member function was added to RTPSession, allowing you to change received RTP or RTCP data. This can be used to e.g. decrypt the packets.
Example 6 uses one of them
It's possible that OnValidatedRTPPacket already deletes the packet, making the pointer invalid.
This shouldn't happen since the number of CSRCs comes from four bits in the RTP header. But better safe than sorry.
Uses the abort descriptor SendAbortSignal everytime a packet is injected, but this buffer can fill up.
Fix rtpsecuresession.cpp when thread is not supported
Fix rtpsecuresession.cpp when thread is not supported
Avoid `using namespace std` to allow c++14 compilation
Add support for libsrtp2
Fix typos in src/rtperrors.cpp
… port number by the use of a colon, while enclosing the address in square brackets, just as "netstat" does. That is, don't use the slash symbol for this, because it can be confused for the subnet (see the CIDR notation). Here's a discussion on the topic: https://serverfault.com/a/205794
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPv6 - Adjusted the string formatting to separate the address and the port number by the use of a colon, while enclosing the address in square brackets, just as "netstat" does. That is, don't use the slash symbol for this, because it can be confused for the subnet (see the CIDR notation). Here's a discussion on the topic: https://serverfault.com/a/205794