Improved position API
#146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-mie6
added a commit
that referenced
this pull request
Jan 22, 2023
* Version bump to 4.2 * Fixed badges * Improved `position` API (#146) * Added positions object * deprecated old position stuff * Stopped coverage run unless it's actually needed (pr to master, or on master) * Fixed CI test coverage skipping * Apparently base_ref is a different style to ref... * Changed deprecation for Lexer inheritance to now, backport/4.1 needs to undo its deprecation * Deprecated old error combinators, added unexpectedLegacy (#147) * disabled test coverage for deprecated fastfail and fastunexpected * Replaced deprecated implementations by slow (but stable versions) * Error pattern combinators (#148) * Added the VerifiedErrors extension class in patterns object, added correct partial amending semantics * satisfied MiMA * Changed names of new combinators, no need to jump through so many hoops now! * verify -> verified * Added intrinsic, needs testing * Added correct partial amend behaviour onto deprecated deoptimised combinators * Fixed bug where string terminal escapes relabelling * removed partial amend semantics on verifiedX, because it's evil: we won't be exposing it! * Added comment about the future improved partial amend * Fix name of instruction * Doc stubs * Add `dislodge` and `amendThenDislodge` combinators (#149) * Exposed amendThenDislodge and dislodge * Added tests * documentation * Introduce `unexpectedWhenWithReason` (#151) * Added combinator and generalised machinery * Removed defunct combinators from lexer * documentation * tests written * Added comment about spanWith, I'm not going to include it for now * Renamed combinator, it's a bit better with the When at the end * Documented the 1 indexing * Added position tests * position module description * Added positions to rootdoc * patterns documentation * sbt and README updated * update workflow * Fixed style issues * Added tests for verifiedFail * Full testing of new verified errors combinators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
positionobject to house the existing position functionality (deprecating the old functionality), and exposes a newoffsetcombinator.