Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Merging entrenched errors at different depths drops entrenchment level #226

Closed
j-mie6 opened this issue Jan 30, 2024 · 0 comments · Fixed by #233 · May be fixed by #223
Closed

[BUG] Merging entrenched errors at different depths drops entrenchment level #226

j-mie6 opened this issue Jan 30, 2024 · 0 comments · Fixed by #233 · May be fixed by #223
Assignees
@j-mie6
Labels
bug Something isn't working

Comments

@j-mie6
Copy link
Owner

j-mie6 commented Jan 30, 2024

When two errors merged and one is entrenched and the other is not, merging will drop any entrenchment, losing the protection of the error. Instead merged errors need to take the max of the entrenchment level.
@j-mie6 j-mie6 added bug Something isn't working backport 4.4 backport 4.5 labels Jan 30, 2024
@j-mie6 j-mie6 self-assigned this Jan 30, 2024
@j-mie6 j-mie6 mentioned this issue Jan 30, 2024
Draft
26 tasks
j-mie6 added a commit that referenced this issue Jan 30, 2024
@j-mie6
hotfix for #226
f9db3ec
@j-mie6 j-mie6 linked a pull request Jan 30, 2024 that will close this issue
Parsley 5.0 #223
Draft
26 tasks
j-mie6 added a commit that referenced this issue Apr 8, 2024
@j-mie6
backport for #226
541473e
@j-mie6 j-mie6 mentioned this issue Apr 8, 2024
Merged
j-mie6 added a commit that referenced this issue Apr 8, 2024
@j-mie6
backport for #226
d302775
@j-mie6 j-mie6 closed this as completed in 15d761a Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j-mie6 j-mie6

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Backports for 4.5 from 5.0 j-mie6/parsley
Parsley 5.0 j-mie6/parsley
1 participant
@j-mie6