Added config file settings validation

crates/uv-settings/src/lib.rs

@@ -12,8 +12,11 @@ use uv_warnings::warn_user;
 pub use crate::combine::*;
 pub use crate::settings::*;
 
+use crate::validation::{Context, ValidationError, Validator};
+
 mod combine;
 mod settings;
+mod validation;
 
 /// The [`Options`] as loaded from a configuration file on disk.
 #[derive(Debug, Clone)]
@@ -47,6 +50,7 @@ impl FilesystemOptions {
         match read_file(&file) {
             Ok(options) => {
                 tracing::debug!("Found user configuration in: `{}`", file.display());
+                options.validate(&Context { path: &file })?;
                 validate_uv_toml(&file, &options)?;
                 Ok(Some(Self(options)))
             }
@@ -71,6 +75,7 @@ impl FilesystemOptions {
 
         tracing::debug!("Found system configuration in: `{}`", file.display());
         let options = read_file(&file)?;
+        options.validate(&Context { path: &file })?;
         validate_uv_toml(&file, &options)?;
         Ok(Some(Self(options)))
     }
@@ -130,6 +135,7 @@ impl FilesystemOptions {
                 }
 
                 tracing::debug!("Found workspace configuration at `{}`", path.display());
+                options.validate(&Context { path: &path })?;
                 validate_uv_toml(&path, &options)?;
                 return Ok(Some(Self(options)));
             }
@@ -162,6 +168,7 @@ impl FilesystemOptions {
                 let options = options.relative_to(&std::path::absolute(dir)?)?;
 
                 tracing::debug!("Found workspace configuration at `{}`", path.display());
+                options.validate(&Context { path: &path })?;
                 return Ok(Some(Self(options)));
             }
             Err(err) if err.kind() == std::io::ErrorKind::NotFound => {}
@@ -177,6 +184,7 @@ impl FilesystemOptions {
         tracing::debug!("Reading user configuration from: `{}`", path.display());
 
         let options = read_file(path)?;
+        options.validate(&Context { path })?;
         validate_uv_toml(path, &options)?;
         Ok(Self(options))
     }
@@ -577,6 +585,9 @@ pub enum Error {
         value: String,
         err: String,
     },
+
+    #[error(transparent)]
+    Validation(#[from] ValidationError),
 }
 
 #[derive(Copy, Clone, Debug)]

crates/uv-settings/src/validation.rs

@@ -0,0 +1,48 @@
+use std::path::{Path, PathBuf};
+
+use uv_fs::Simplified;
+
+use crate::{GlobalOptions, Options};
+
+pub(crate) trait Validator<Context = (), Err = ValidationError> {
+    fn validate(&self, ctx: &Context) -> Result<(), Err>;
+}
+
+pub(crate) struct Context<'p> {
+    pub path: &'p Path,
+}
+
+impl<'path> Validator<Context<'path>> for Options {
+    /// Validate that an [`Options`] struct has correct values.
+    fn validate(&self, ctx: &Context<'path>) -> Result<(), ValidationError> {
+        let Self { globals, .. } = self;
+        globals.validate(ctx)
+    }
+}
+
+#[derive(thiserror::Error, Debug)]
+pub enum ValidationError {
+    #[error(transparent)]
+    GlobalOptions(#[from] GlobalOptionsError),
+}
+
+impl<'path> Validator<Context<'path>> for GlobalOptions {
+    /// Validate that a [`GlobalOptions`] struct has correct values.
+    fn validate(&self, ctx: &Context<'path>) -> Result<(), ValidationError> {
+        let Self {
+            preview,
+            preview_features,
+            ..
+        } = self;
+        if preview.is_some() && preview_features.is_some() {
+            return Err(GlobalOptionsError::PreviewFeatures(ctx.path.to_path_buf()).into());
+        }
+        Ok(())
+    }
+}
+
+#[derive(thiserror::Error, Debug)]
+pub enum GlobalOptionsError {
+    #[error("Failed to parse: `{}`. Cannot specify both `preview` and `preview-features`.", _0.user_display())]
+    PreviewFeatures(PathBuf),
+}