Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Release/validation skip #64

Closed
wants to merge 1 commit into from

Conversation

j-d-carmichael
Copy link
Owner

Please ensure your pull request:

  • Includes additions to the docs, found in the docs/readme file, as required
  • Includes a new line in the changelog titling the change
  • The new and changed code you have written is unit tested and passes the eslint
  • The body of the text for this PR includes enough text for a reviewer to understand the context of the change

@j-d-carmichael j-d-carmichael changed the title Release/validation skip WIP: Release/validation skip Oct 9, 2021
@j-d-carmichael j-d-carmichael force-pushed the release/validation-skip branch from 4e5796a to b5008d3 Compare October 9, 2021 15:01
@j-d-carmichael
Copy link
Owner Author

Super weird - i hit swagger parse issues now:

Trace: TypeError: Class is not a constructor
    at SwaggerParser.validate (/home/carmichael/code/opensource/boats/node_modules/@apidevtools/swagger-parser/lib/index.js:122:18)
    at /home/carmichael/code/opensource/boats/src/validate.ts:29:15
    at new Promise (<anonymous>)
    at Validate.openapi (/home/carmichael/code/opensource/boats/src/validate.ts:25:12)
    at Validate.decideThenValidate (/home/carmichael/code/opensource/boats/src/validate.ts:20:19)
    at exports.default (/home/carmichael/code/opensource/boats/src/bundlerSwaggerParse.ts:29:22)
    at async parseCli (/home/carmichael/code/opensource/boats/src/cli.ts:61:27)
    at catchHandle (/home/carmichael/code/opensource/boats/src/cli.ts:75:11)

It makes little sense though as the parser has not changed :/

@j-d-carmichael j-d-carmichael mentioned this pull request Oct 9, 2021
1 task
@j-d-carmichael j-d-carmichael deleted the release/validation-skip branch December 8, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant