Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IZPACK-1402] Maven Build: A mechanism to include only specified Maven properties in the installer #1009

Merged
merged 2 commits into from
Jan 27, 2025
Merged

[IZPACK-1402] Maven Build: A mechanism to include only specified Maven properties in the installer #1009

merged 2 commits into from
Jan 27, 2025

Conversation

hiteshbosamiya
Copy link

No description provided.

@hiteshbosamiya hiteshbosamiya marked this pull request as draft January 16, 2025 06:42
@hiteshbosamiya hiteshbosamiya force-pushed the IZPACK-1402 branch 3 times, most recently from 295e469 to f04694c Compare January 16, 2025 06:59
@hiteshbosamiya
Copy link
Author

@reinhapa & @akuhtz, there is already a PR #786 created by Frank Cornelis. I had some discussion with him through comments in https://izpack.atlassian.net/browse/IZPACK-1402 and based on that I have raised this draft PR. Can you please look into the same? I have also requested Frank Cornelis to review this draft PR.

@reinhapa
Copy link
Member

@reinhapa & @akuhtz, there is already a PR #786 created by Frank Cornelis. I had some discussion with him through comments in https://izpack.atlassian.net/browse/IZPACK-1402 and based on that I have raised this draft PR. Can you please look into the same? I have also requested Frank Cornelis to review this draft PR.

@hiteshbosamiya I'm not very used in the Maven site of things though. If you and @akuhtz come to an agreement it is fine by me.

akuhtz
akuhtz approved these changes Jan 20, 2025
View reviewed changes
Copy link

@akuhtz akuhtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@hiteshbosamiya hiteshbosamiya marked this pull request as ready for review January 21, 2025 03:16
@hiteshbosamiya hiteshbosamiya mentioned this pull request Jan 21, 2025
Closed
@reinhapa reinhapa merged commit 5fcfed3 into izpack:master Jan 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akuhtz akuhtz akuhtz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hiteshbosamiya @reinhapa @akuhtz