-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Support associations and embeds - cont. #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changeset Plugged that into PaperTrail.insert - the test works now.
non-bang functions now return a list of assoc_versions in the result map bang functions were upgraded to also insert assoc-related versions
so SQL query debug log won't pollute the test output
use changeset.data when passing a changeset into get_all_children
14 tasks
…on of the parent entity:
How's progress ? I'd love to see embedded_schema support |
Although, this will significantly complicate the library usage and tests further, with the advent of recent PaperTrail.Multi adjustments, I'm willing to review this feature once its out of WIP. |
izelnakri
force-pushed
the
master
branch
10 times, most recently
from
March 1, 2020 07:10
113ce09
to
98522f0
Compare
izelnakri
force-pushed
the
master
branch
2 times, most recently
from
October 1, 2020 20:42
a06c813
to
675d502
Compare
Closing this PR as the requested feature implemented in #112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to push foward the work done in #21. Currently only rebased on latest master everything else is the same.