(chore): add support for using PaperTrail.Multi directly #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! Thank you for your contribution @fv316 ! Testing them now! |
mayel
pushed a commit
to bonfire-networks/paper_trail
that referenced
this pull request
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The direct usage of the
PaperTrail.Multimodule is very hard as it does not have support for multiple updates or deletes in a transaction. Adding the capability of defining the keys for the model and versions in theupdateanddeletefunctions will add a lot of functionality and allow people to use this module directly. After mergingPaperTrailwould support multiple stage transactions (in the non-strict mode). This would be very useful to me.