Refactor Duplicated Code #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maennchen
commented
Dec 15, 2020
•
maennchen
commented
- Merge Enable capture_log to make test output readable #123 first
maennchen
commented
Dec 15, 2020
maennchen
force-pushed
the
refactor_duplicated_code
branch
from
b3d2300
to
1aaf462
Compare
|
@maennchen merged the first 2 PRs, this one also looks good to me. Could you fix the merge conflict and push the changes, then I'll merge it. Thanks! |
maennchen
force-pushed
the
refactor_duplicated_code
branch
from
1aaf462
to
71fea0c
Compare
|
@izelnakri Rebased. |
mayel
pushed a commit
to bonfire-networks/paper_trail
that referenced
this pull request
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.