Skip to content

esm: add initialize hook #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
izaakschroeder wants to merge 4 commits into from
Closed

esm: add initialize hook #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
567e32b
src: fix nullptr access on realm
hybrist Jul 18, 2023
38cc538
doc: refactor node-api support matrix
mhdawson Jul 19, 2023
a2fc4a3
esm: unflag `Module.register` and allow nested loader `import()`
izaakschroeder Jul 19, 2023
ddfa9d4
esm: add `initialize` hook
izaakschroeder Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions doc/api/errors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1233,23 +1233,6 @@ provided.
Encoding provided to `TextDecoder()` API was not one of the
[WHATWG Supported Encodings][].

<a id="ERR_ESM_LOADER_REGISTRATION_UNAVAILABLE"></a>

### `ERR_ESM_LOADER_REGISTRATION_UNAVAILABLE`

<!-- YAML
added: REPLACEME
-->

Programmatically registering custom ESM loaders
currently requires at least one custom loader to have been
registered via the `--experimental-loader` flag. A no-op
loader registered via CLI is sufficient
(for example: `--experimental-loader data:text/javascript,`;
do not omit the necessary trailing comma).
A future version of Node.js will support the programmatic
registration of loaders without needing to also use the flag.

<a id="ERR_EVAL_ESM_CANNOT_PRINT"></a>

### `ERR_EVAL_ESM_CANNOT_PRINT`
Expand Down
102 changes: 25 additions & 77 deletions doc/api/n-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,106 +245,54 @@ from version 3 with some additions. This means that it is not necessary
to recompile for new versions of Node.js which are
listed as supporting a later version.

This table may not be up to date in older streams, the most up to date
information is in the latest API documentation in:
[Node-API version matrix](https://nodejs.org/docs/latest/api/n-api.html#node-api-version-matrix)

<!-- For accessibility purposes, this table needs row headers. That means we
can't do it in markdown. Hence, the raw HTML. -->

<table>
<tr>
<td></td>
<th scope="col">1</th>
<th scope="col">2</th>
<th scope="col">3</th>
</tr>
<tr>
<th scope="row">v6.x</th>
<td></td>
<td></td>
<td>v6.14.2*</td>
</tr>
<tr>
<th scope="row">v8.x</th>
<td>v8.6.0**</td>
<td>v8.10.0*</td>
<td>v8.11.2</td>
<th>Node-API version</th>
<th scope="col">Supported In</th>
</tr>
<tr>
<th scope="row">v9.x</th>
<td>v9.0.0*</td>
<td>v9.3.0*</td>
<td>v9.11.0*</td>
<th scope="row">9</th>
<td> 20.3.0+, 21.0.0 and all later versions</td>
</tr>
<tr>
<th scope="row">≥ v10.x</th>
<td>all releases</td>
<td>all releases</td>
<td>all releases</td>
<th scope="row">8</th>
<td>v12.22.0+, v14.17.0+, v15.12.0+, 16.0.0 and all later versions</td>
</tr>
</table>

<table>
<tr>
<td></td>
<th scope="col">4</th>
<th scope="col">5</th>
<th scope="col">6</th>
<th scope="col">7</th>
<th scope="col">8</th>
<th scope="row">7</th>
<td>v10.23.0+, v12.19.0+, v14.12.0+, 15.0.0 and all later versions</td>
</tr>
<tr>
<th scope="row">v10.x</th>
<td>v10.16.0</td>
<td>v10.17.0</td>
<td>v10.20.0</td>
<td>v10.23.0</td>
<td></td>
<th scope="row">6</th>
<td>v10.20.0+, v12.17.0+, 14.0.0 and all later versions</td>
</tr>
<tr>
<th scope="row">v11.x</th>
<td>v11.8.0</td>
<td></td>
<td></td>
<td></td>
<td></td>
<th scope="row">5</th>
<td>v10.17.0+, v12.11.0+, 13.0.0 and all later versions</td>
</tr>
<tr>
<th scope="row">v12.x</th>
<td>v12.0.0</td>
<td>v12.11.0</td>
<td>v12.17.0</td>
<td>v12.19.0</td>
<td>v12.22.0</td>
<th scope="row">4</th>
<td>v10.16.0+, v11.8.0+, 12.0.0 and all later versions</td>
</tr>
<tr>
<th scope="row">v13.x</th>
<td>v13.0.0</td>
<td>v13.0.0</td>
<td></td>
<td></td>
<td></td>
</tr>
<tr>
<th scope="row">v14.x</th>
<td>v14.0.0</td>
<td>v14.0.0</td>
<td>v14.0.0</td>
<td>v14.12.0</td>
<td>v14.17.0</td>
<tr>
<th scope="row">3</th>
<td>v6.14.2*, 8.11.2+, v9.11.0+*, 10.0.0 and all later versions</td>
</tr>
<tr>
<th scope="row">v15.x</th>
<td>v15.0.0</td>
<td>v15.0.0</td>
<td>v15.0.0</td>
<td>v15.0.0</td>
<td>v15.12.0</td>
<th scope="row">2</th>
<td>v8.10.0+*, v9.3.0+*, 10.0.0 and all later versions</td>
</tr>
<tr>
<th scope="row">v16.x</th>
<td>v16.0.0</td>
<td>v16.0.0</td>
<td>v16.0.0</td>
<td>v16.0.0</td>
<td>v16.0.0</td>
<th scope="row">1</th>
<td>v8.6.0+**, v9.0.0+*, 10.0.0 and all later versions</td>
</tr>
</table>

Expand Down
5 changes: 0 additions & 5 deletions lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,11 +1036,6 @@ E('ERR_ENCODING_INVALID_ENCODED_DATA', function(encoding, ret) {
}, TypeError);
E('ERR_ENCODING_NOT_SUPPORTED', 'The "%s" encoding is not supported',
RangeError);
E('ERR_ESM_LOADER_REGISTRATION_UNAVAILABLE', 'Programmatically registering custom ESM loaders ' +
'currently requires at least one custom loader to have been registered via the --experimental-loader ' +
'flag. A no-op loader registered via CLI is sufficient (for example: `--experimental-loader ' +
'"data:text/javascript,"` with the necessary trailing comma). A future version of Node.js ' +
'will remove this requirement.', Error);
E('ERR_EVAL_ESM_CANNOT_PRINT', '--print cannot be used with ESM input', Error);
E('ERR_EVENT_RECURSION', 'The event "%s" is already being dispatched', Error);
E('ERR_FALSY_VALUE_REJECTION', function(reason) {
Expand Down
Loading