-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--no-prompt command line option for unattended mode #17
base: master
Are you sure you want to change the base?
Conversation
@gotson I temporarily pulled this, plus #14, into my forked master. I haven't gotten around to manually merging in your forced year option. Just wondering if you'd be interested in adding documentation to the readme and the -H command in app to show info around the unattended flags and new features. Also, I have a branch I'm testing to accomodate for the Index out of range error (#3) that seems to be tied to torrents that have no artist record. I reviewed the API on the RED wiki and a few example torrents that hit me or a few other users - no artist. One had a composer, a few performers, and a conductor, and one had a DJ. I built in some nested logic to first check for multiple composers, then 1 composer, then 1 DJ, to try and avoid the error crash. Not sure how often iw00t is updating this as he indicated he's not working on the python branch anymore due to the new C++ development. |
My 3 PRs are available in
Argparse generates |
@gotson I saw the argparse, I meant in the readme. I've added it to my master readme. Thanks for all your work on this! |
I realized that shortening the folder name arbitrarily could lead to trumpable torrents. I will try to revisit this by applying some patterns instead. |
I have revamped the shortening algo, it will try to shorten by removing some attributes from the name. Full name is:
If the name is too long, it will try to drop in that order:
If everything fails, it will shorten the remaining (album) by trimming extra characters. |
There is still issues with this branch with regard to romanization, ie duplicate or incorrect romanization, of which i've been contacted by a moderator about. Eg, see: torrents.php?id=1242969&torrentid=3135251#torrent3135251 You'll Melt More! (ゆるめるモ!) - Surpriser (サプライザー) [2020] [Album] is the torrent group Source folder name: /ゆるめるモ! - サプライザー {YOU'LL - YLRC-038} (2020) [24bit WEB-FLAC] Something to be aware of for others if they're not paying attention. |
Isn't this because of the unicode conversion, which was there before my changes? In the current version, if the folder is not too long, the folder will be converted anyway and romanization would happen anyway. |
Yes, what I meant to say is because of the unattended feature, people may not catch that the romanization will happen automatically (and incorrectly due to the master branch). |
This adds a
-P
--no-prompt
command line option that will remove all prompts for user input: