Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node versions supported? #584

Closed
rexxars opened this issue Jul 16, 2018 · 2 comments
Closed

Node versions supported? #584

rexxars opened this issue Jul 16, 2018 · 2 comments

Comments

@rexxars
Copy link

rexxars commented Jul 16, 2018

Hi,

The package.json file does not declare which node versions are supported. I'm trying to use this as part of a project which supports Node 6, but it seems the version of source-map that is depended on is node 8 and above. Would you consider downgrading to source-map@^0.5.6?
@ivogabe
Copy link
Owner

ivogabe commented Sep 11, 2018

The new version of source-map included some performance improvements, so I would like to keep this version. They are now using WebAssembly, which requires Node 8+. Is there a reason you can't upgrade to Node 8+?

Related: mozilla/source-map#313

@ivogabe
Copy link
Owner

ivogabe commented Sep 11, 2018

Though we should add an engine field to package.json to denote this requirement.

ivogabe added a commit that referenced this issue Sep 11, 2018
@ivogabe
Set node 8 as a minimum requirement (#584)
ec59c81
@ivogabe ivogabe closed this as completed Nov 30, 2018
@stevengum stevengum mentioned this issue Jun 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rexxars @ivogabe