feat: move the Question Pack apiVersion to lakespeak.net - #63
Merged
Conversation
The project's site is at lakespeak.net, so the schema identifier follows it. `pack init` now scaffolds `apiVersion: lakespeak.net/v1alpha1`, and the schema, docs, README and example pack say the same. Packs that declare `lakespeak.dev/v1alpha1` still load. The loader accepts both spellings and the schema lists both in an enum. The identifier is a name rather than a URL and nothing resolves it, so rejecting the old one would break every pack already committed to somebody's repository and buy nothing in return. The error message quotes only the current spelling, so a genuine typo still points at the right answer. Covered by a test that fails when the legacy branch is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project's site is at lakespeak.net, so the schema identifier follows it.
pack initnow scaffoldsapiVersion: lakespeak.net/v1alpha1, and the JSON schema,docs/question-packs.md, the README and the example pack agree.Existing packs keep working
QuestionPackLoaderaccepts both spellings and the schema lists both in anenum. The identifier is a name rather than a URL — nothing resolves it — so rejectinglakespeak.dev/v1alpha1would break every pack already committed to somebody's repository and buy nothing. The validation message quotes only the current spelling, so a genuine typo still points at the right answer.Verification
New test
Still_parses_a_pack_written_before_the_domain_moved, proven meaningful by removing the legacy branch and watching it go red, then restoring it and watching it go green.Full suite: 231 passed, 0 failed across Genie, Application, QuestionPacks, Contract and Cli.
dotnet format --verify-no-changesclean.