fix: mark prereleases as prereleases - #35
Merged
Merged
Conversation
…sh taught action-gh-release defaults to a full release. 0.1.0-preview.1 therefore published as "Latest release", telling everyone arriving at the repo that a preview is the stable build. Now derived from the version: SemVer treats any hyphen as a prerelease marker. The already-published release was corrected by hand. RELEASING.md now records that the policy was verified by an actual publish rather than by reading the form, and quotes the exact error nuget.org returns on a field mismatch. It names both the expected and actual value, which turns a guess into a one-line fix -- worth writing down because the whole point of the token exchange failing closed is that you get to read the error and retry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
softprops/action-gh-releasedefaults to a full release.0.1.0-preview.1therefore published as "Latest release" — telling anyone arriving at the repo that a preview is the stable build.Now derived from the version, since SemVer treats any hyphen as a prerelease marker:
The already-published release was corrected by hand with
gh release edit --prerelease.Also
RELEASING.mdnow records that the trusted-publishing policy was verified by an actual publish, not by reading the form — and quotes the exact error nuget.org returns on a field mismatch:It names both sides, which turns a guess into a one-line fix. Worth writing down, because the value of the exchange failing closed is precisely that you get to read the error and retry — no package was pushed, no version burnt.