docs: the release approval gate is not configured yet - #25
Merged
Conversation
RELEASING.md described the nuget environment gate as though it were in force. It is not: the repository has no environments and no secrets, and a workflow naming an environment that does not exist does not fail -- GitHub creates it implicitly with no protection rules. So the sentence "stops at the nuget environment gate, approve it" described a step that would not happen. Records the real state, why an unconfigured environment is silently permissive, and the two commands to verify both prerequisites before a first release. Verified by running the release workflow's rehearsal path (publish unticked) on main: version resolved to 0.0.0-dev.1, build/test/pack/binaries/checksums/SBOM/ provenance all succeeded, publish job skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RELEASING.mddescribed thenugetenvironment gate as if it were in force. It is not — the repository has no environments and no secrets.This matters because a workflow naming an environment that does not exist does not fail: GitHub creates it implicitly with no protection rules. The document told a reader the run would stop for approval, when it would not.
Now states the real state, explains why an unconfigured environment is silently permissive, and gives the two commands to verify both prerequisites before a first release.
Verified: ran the release workflow's rehearsal path (
publishunticked) againstmain— version resolved to0.0.0-dev.1; build, test, pack, binaries, checksums, SBOM and provenance attestation all succeeded; thepublishjob was skipped as designed. Run 30694686193