Show bound parameters everywhere, and test CLI output - #23
Merged
Conversation
…operly The bind values reached JSON only, so a terminal reader or a committed Markdown report saw placeholders and had to guess what the statement actually ran with. Both now render them beneath the SQL, which removes the limitation rather than documenting it. The roadmap's CLI output tests existed as an unchecked box. Eighteen now assert the properties that are invisible when they break: a table renders at 40, 80 and 200 columns without throwing; non-ASCII survives rendering; a null cell stays distinguishable from an empty one; a cell carrying ANSI cannot clear the screen or draw something resembling this tool's own prompt; and truncation by Databricks is worded differently from a local row cap, because conflating them tells someone their export is incomplete when only the screen was capped. 167 tests, up from 149.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the last two actionable items from the review panel and the v0.1 roadmap.
Bound parameters reached JSON only. A terminal reader or a committed Markdown report saw SQL with placeholders and had to guess what it ran with. Both now render the values beneath the statement — the limitation is removed rather than documented.
The roadmap's CLI output tests were an unchecked box. Eighteen tests now assert the properties that are invisible when they break:
167 tests, up from 149.