Test the exit-code contract, and fill the last empty test project - #10
Merged
Conversation
docs/commands.md promises that an existing exit code never changes meaning, and scripts branch on that. Nothing tested it: ExitCode.From had no coverage, and LakeSpeak.Cli.Tests was an empty project — the same decorative-project problem the live test suite had. Sixteen tests now pin the mapping from every GenieFailureKind, the documented numbers themselves, that every kind is mapped at all, and that only success is zero. A renumbering refactor or a new failure kind added without a mapping now fails the build instead of surfacing when a user first hits that failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/commands.mdstates that an existing exit code never changes meaning, and scripts branch on it. Nothing tested that, andLakeSpeak.Cli.Testswas an empty project — the same decorative-project problem the live suite had before PR #9.Sixteen tests pin the mapping from every
GenieFailureKind, the documented numbers themselves, that every kind is mapped at all, and that only success is zero.Found by running the
auto-developmentpipeline's requirements-traceability gate against the shipped code.109 tests green.