Add Optional Dependencies Configuration #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spencer516 thanks a lot for this one mate, looks great. We're actually merging this into ember-d3, so I might rebase your changes over my branch on there, or you could open a PR there against this one ivanvanderbyl/ember-d3#8 |
|
Oh deluxe. I'm happy to do whatever is easiest. Should I open a PR against your fork of ember-d3? Or — does it make more sense for you to rebase against this? (Weird situation, this one is — wish I'd seen that PR before I tackled this! :-P ) |
|
I'll try to tackle this one this weekend. Leave as is and I'll pull them together. |
|
👍 |
|
Closing, all changes are now part of https://github.com/brzpegasus/ember-d3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to define an
onlyconfiguration which would make the consuming app only need to import only the required dependencies, rather than every d3 dependency.I've also added a small handful of tests for the
index.jsfile (npm run node-test). Test coverage isn't great for everything going on in there — but this is at least a start.